Geostory scheleton#4014
Merged
offtherailz merged 8 commits intogeosolutions-it:C039_geostoryfrom Jul 26, 2019
Merged
Conversation
Contributor
allyoucanmap
left a comment
There was a problem hiding this comment.
In general about classes I would use this approach:
ms-geostory-component--part
web/client/reducers/geostory.js
Outdated
| * "mode": "edit", // 'edit' or 'view', | ||
| * "currentStory": { | ||
| * // sessions | ||
| * "sessions": [ |
| style={{ | ||
| padding: '8px 16px', | ||
| borderBottom: '1px solid #ddd' | ||
| }}> |
Contributor
There was a problem hiding this comment.
I would prefer to move inline style to the less file in particular in the case they use colors.
We could use a className like 'ms-geostoty-builder--header' or similar.
| const res = 1080 / 1920; | ||
| const height = width * res; | ||
| return ( | ||
| <div style={{ position: 'relative', width, height }}> |
Contributor
There was a problem hiding this comment.
We could use a className like 'ms-geostoty-sections--preview' or similar.
| description: `type: ${type}`, | ||
|
|
||
| body: contents | ||
| ? <div style={{ position: 'relative' }}> |
Contributor
There was a problem hiding this comment.
I think this position relative was needed for ContainerDimansion, it had strange behaviours, I don't know it it really needed now.
| * @SectionsPreview | ||
| * @param {object[]} [sections=[]] Array of sections to display | ||
| */ | ||
| export default ({ sections = [] }) => (<SideGrid |
Contributor
There was a problem hiding this comment.
SideGrid needs some style adjustment at application level, in particular for margin and issue inherit from .row and .col styles from bootstrap
|
|
||
| const Text = (props) => { | ||
| return ( | ||
| <div className="geostory-content-text" style={{margin: 20}} onClick={() => { |
Contributor
There was a problem hiding this comment.
We could use a className like 'ms-geostory-content--text' or similar and remove margin 20 from here
| }) => (<BorderLayout className="ms-cascade-story"> | ||
| <ContainerDimensions sections={sections}> | ||
| {({ width, height }) => | ||
| <div style={{ position: 'absolute', width: '100%', height: '100%', overflowY: 'auto'}}> |
Contributor
There was a problem hiding this comment.
We could use a className like 'ms-geostory-cascade-story--container' or similar
| export default ({ | ||
| mode = Modes.VIEW, | ||
| sections = [] | ||
| }) => (<BorderLayout className="ms-cascade-story"> |
Contributor
There was a problem hiding this comment.
We could use a className like 'ms-geostory-cascade-story' or similar
| * Paragraph Section Type. | ||
| * Paragraph is a page block that expands for all it's height | ||
| */ | ||
| export default ({ contents, type, mode }) => (<div className={`section-${type}-contents`}>{contents.map((props) => (<Content mode={mode} {...props}/>))}</div>); |
Contributor
There was a problem hiding this comment.
ms-geostory-section-- ?
| className={`ms-${this.props.storyType}-section${this.props.type ? ` ms-${this.props.type}` : ''}`} | ||
| style={{ | ||
| position: 'relative', | ||
| transform: 'translate3d(0px, 0px, 0px)' |
Contributor
There was a problem hiding this comment.
We can remove this style and maybe use a generel class for all Section
allyoucanmap
approved these changes
Jul 26, 2019
offtherailz
pushed a commit
that referenced
this pull request
Sep 6, 2019
* Geostory scheleton (#4014) * Geostory sections (#4029) Add base structure for geostory scroll handlers and background setup (base support for immersive or cover backgrounds) . * Geostory base text editing and content wrapper (#4033) * Fix #9 Contents - Image (#4038) * Geostory scroll immersive (#4044) * Fix #69 Builder - Section Editor - Section selector - Title (#4063) * Geostory add Section (#4078) * Fix random failure of getFeatureInfoOnFeatureInfoClick WMS test (#4091) (#4099) * Fix issue 78 Load story configuration (C039_geostory) (#4096) * Fix issue 78 Load story configuration * removed unneeded action in epic stream * removed unneeded comment * skip failing test * Fix issue 62 Media Editor - Image (C039_geostory) (#4101) * First version of media editor (missing tests) * Adding tests and documentation * adding modify logic for media image with tests * mediaEditor closed by default * update node version to 8.6.0 in .travis.yml * skip failing test for the moment * Geostory - Normal editor - Title (C039_geostory) (#4102) * Fix issue 75,71 added content toolbar everywhere and media editor and media section (C039_geostory) (#4107) * Fix Background content toolbar (C039_geostory) * it contains also tests * added editing for media and correct update of resource id * also restructured the sample story for new layout of paragraph * adding media toolbar on every Image * missed one test in prevois commit * Adding Media Section for GeoStory * issue 71 * add some styles for immersive layout * Removed section typemedia * Fixed missing parts of SectionTemplate removals * Fixed styles and minor changes * fix add button position in geostory column content * Fix media section toolbar as paragraph * removed .only in tests * Add column and immersive tests * revert error commit * revert error commit * Fixed immersive tests * Fixed column test * Add remove button for images and immersive background * Fixed remove buttons * improve style of cascade layout * Fixed array remove * * removed path geostory * image placeholder * fix tests * Add default resources for newgeostory fix edit for empty background * fix scrollbar in media editor * Add remove to text. Add recursive conainer removal * add tests for column and actions and content toolbars * resotred tests.webpack.js changes committed in error * removed temp comment * update toolbar position and patterns * fix failing epic test * fix edit media for media inside immersive columns * Add auto scroll for new content * fix lint error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add GeoStory base structure:
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Does this PR introduce a breaking change? (check one with "x", remove the other)