Removes console logs from browser from karma testing output#3207
Merged
offtherailz merged 1 commit intogeosolutions-it:masterfrom Oct 4, 2018
Merged
Removes console logs from browser from karma testing output#3207offtherailz merged 1 commit intogeosolutions-it:masterfrom
offtherailz merged 1 commit intogeosolutions-it:masterfrom
Conversation
11 tasks
offtherailz
reviewed
Oct 4, 2018
|
|
||
| browserConsoleLogOptions: { | ||
| terminal: true, | ||
| level: 'DISABLE' |
Member
There was a problem hiding this comment.
Where did you found this option? I see LOG_DISABLE here
Member
There was a problem hiding this comment.
I've seen the browserConsoleLogOptions. I meant level: 'DISABLE' instead of options.LOG_DISABLE. I'm sure that @mbarto used the right value, but I'd like to check from where this string comes.
tdipisa
pushed a commit
that referenced
this pull request
Oct 4, 2018
* Revert "Removes console logs from browser from karma testing output (#3207)" This reverts commit 264ef58. * Revert "Fix #3209 show/hide title translations in layer settings (#3210)" This reverts commit 415e63d. * Revert "Fixes #2669: use https version of geosolutions maven repo (#3182)" This reverts commit dc4084c. * Revert "Automatic definition of proj codes from configuration in OpenLayers maps (#3133)" This reverts commit 70ee3b9. * Revert "Fix #3192 setting the default layer as object (#3199)" This reverts commit fe50170. * Revert "Fix #2298 de-DE translation fix (#3205)" This reverts commit e39348a. * Revert "hiding div to allow playing/showing the video (#3188)" This reverts commit a7c9e66.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix #3161.
Completely removes console.log output from browser from karma-runner output during tests, so that test report is clean and does not contain browser generated stuff.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
What is the current behavior? (You can also link to an open issue here)
A lot of noise in test running output, mostly setState error from react-widgets NumberPicker, but not limited to that.
What is the new behavior?
No noise from browser output, and a cleaner report.
Does this PR introduce a breaking change? (check one with "x", remove the other)
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: