Skip to content

Automatic definition of proj codes from configuration in OpenLayers maps#3133

Merged
tdipisa merged 2 commits intogeosolutions-it:masterfrom
mbarto:fix_proj_support_for_ol
Sep 28, 2018
Merged

Automatic definition of proj codes from configuration in OpenLayers maps#3133
tdipisa merged 2 commits intogeosolutions-it:masterfrom
mbarto:fix_proj_support_for_ol

Conversation

@mbarto
Copy link
Copy Markdown
Contributor

@mbarto mbarto commented Jul 31, 2018

Description

Custom projections are not initialized for ol, so they don't work if used for a map.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
proj4 is initialized with custom defined projections, but ol is not in synch.

What is the new behavior?
ol is synchronized with custom projections definitions in localConfig

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@ghost ghost assigned mbarto Jul 31, 2018
@coveralls
Copy link
Copy Markdown

coveralls commented Jul 31, 2018

Coverage Status

Coverage increased (+0.2%) to 81.075% when pulling e3c49e4 on mbarto:fix_proj_support_for_ol into c0927cf on geosolutions-it:master.

Copy link
Copy Markdown
Member

@offtherailz offtherailz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit test needed

offtherailz
offtherailz previously approved these changes Aug 9, 2018
@offtherailz offtherailz dismissed their stale review August 9, 2018 08:48

duplicated

@tdipisa tdipisa closed this Sep 27, 2018
@tdipisa tdipisa reopened this Sep 27, 2018
@ghost ghost assigned tdipisa Sep 27, 2018
@tdipisa tdipisa closed this Sep 28, 2018
@tdipisa tdipisa reopened this Sep 28, 2018
@tdipisa tdipisa merged commit 70ee3b9 into geosolutions-it:master Sep 28, 2018
offtherailz added a commit that referenced this pull request Oct 4, 2018
tdipisa pushed a commit that referenced this pull request Oct 4, 2018
* Revert "Removes console logs from browser from karma testing output (#3207)"

This reverts commit 264ef58.

* Revert "Fix #3209 show/hide title translations in layer settings (#3210)"

This reverts commit 415e63d.

* Revert "Fixes #2669: use https version of geosolutions maven repo (#3182)"

This reverts commit dc4084c.

* Revert "Automatic definition of proj codes from configuration in OpenLayers maps (#3133)"

This reverts commit 70ee3b9.

* Revert "Fix #3192 setting the default layer as object (#3199)"

This reverts commit fe50170.

* Revert "Fix #2298 de-DE translation fix (#3205)"

This reverts commit e39348a.

* Revert "hiding div to allow playing/showing the video (#3188)"

This reverts commit a7c9e66.
@tdipisa tdipisa added this to the 2018.03.00 milestone Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants