fix #10924: fix the regression issue of disable ip filter#11683
Merged
tdipisa merged 1 commit intogeosolutions-it:masterfrom Nov 14, 2025
Merged
fix #10924: fix the regression issue of disable ip filter#11683tdipisa merged 1 commit intogeosolutions-it:masterfrom
tdipisa merged 1 commit intogeosolutions-it:masterfrom
Conversation
- unit test is added for RulesDataGrid plugin
offtherailz
approved these changes
Nov 13, 2025
Member
offtherailz
left a comment
There was a problem hiding this comment.
My code inspection is ok, let's do the dev env tests.
Member
|
@ElenaGallo please check this and let us know if we @mahmoudadel54 can backport |
mahmoudadel54
added a commit
to mahmoudadel54/MapStore2
that referenced
this pull request
Nov 14, 2025
…ter (geosolutions-it#11683) - unit test is added for RulesDataGrid plugin
Contributor
|
Test passed, @mahmoudadel54 please backport to 2025.02.xx. Thanks |
mahmoudadel54
added a commit
to mahmoudadel54/MapStore2
that referenced
this pull request
Nov 20, 2025
…ter (geosolutions-it#11683) - unit test is added for RulesDataGrid plugin
Contributor
Author
Backport is done -> #11708 |
tdipisa
pushed a commit
that referenced
this pull request
Nov 20, 2025
…filter (#11683) - unit test is added for RulesDataGrid plugin
allyoucanmap
pushed a commit
that referenced
this pull request
Nov 26, 2025
…filter (#11683) - unit test is added for RulesDataGrid plugin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR includes fixing a regression issue of disable ip filter due to this: https://github.com/geosolutions-it/MapStore2/pull/11063/files#diff-a9732eedb8fc0863a1129b75595b92f3ef557629490f87e935466999b030d6c1R100
I have added a new unit test for the RulesGrid plugin and added a specific unit test for the ip filter.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#10924
What is the new behavior?
The filter ip is shown and not disabled. User can filter by ip in rules grid.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information