Skip to content

#11678: Fix Manage Rule - WMS service is not reachable#11679

Merged
offtherailz merged 1 commit intogeosolutions-it:masterfrom
mahmoudadel54:issue_11678
Nov 14, 2025
Merged

#11678: Fix Manage Rule - WMS service is not reachable#11679
offtherailz merged 1 commit intogeosolutions-it:masterfrom
mahmoudadel54:issue_11678

Conversation

@mahmoudadel54
Copy link
Copy Markdown
Contributor

@mahmoudadel54 mahmoudadel54 commented Nov 13, 2025

Description

This PR fixes a regression issue of missing passing the geofence url to function 'getStylesAndAttributes' here:

MapStore2/web/client/plugins/manager/EditorEnhancer.js

Lines 35 to 36 in 54e9062

if (geoFenceType !== "geofence") {
return getStylesAndAttributes(layer, workspace).do(opts => optionsLoaded(opts))

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

#11678

What is the current behavior?
#11678

What is the new behavior?

For non geofence stand-alone
Now when user can want to add new rule selecting User, Workspace and Layer .

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@mahmoudadel54
geosolutions-it#11678: Fix Manage Rule - WMS service is not reachable
c3b1cfc 
- passing the missing url geofence for non stand-alone geofence to getStylesAndAttributes function in EditorEnahncer
@mahmoudadel54 mahmoudadel54 added this to the 2025.02.00 milestone Nov 13, 2025
@mahmoudadel54 mahmoudadel54 self-assigned this Nov 13, 2025
@mahmoudadel54 mahmoudadel54 linked an issue Nov 13, 2025 that may be closed by this pull request
Manage Rule - WMS service is not reachable #11678
Closed
1 task
@offtherailz offtherailz added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Nov 13, 2025
@offtherailz offtherailz enabled auto-merge (squash) November 14, 2025 11:16
@offtherailz offtherailz merged commit 068a2ac into geosolutions-it:master Nov 14, 2025
6 checks passed
@offtherailz
Copy link
Copy Markdown
Member

offtherailz commented Nov 14, 2025

@ElenaGallo can you please test this on dev?

mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this pull request Nov 14, 2025
@mahmoudadel54
geosolutions-it#11678: Fix Manage Rule - WMS service is not reachable (…
e985a2c 
…geosolutions-it#11679)
@mahmoudadel54 mahmoudadel54 mentioned this pull request Nov 14, 2025
Merged
offtherailz pushed a commit that referenced this pull request Nov 18, 2025
@mahmoudadel54
[Backport c027-2025.01.xx]: Port fixes for rule manager (#11692)
36d5700 
* #11655: Fix Auth token not sent in /rest requests for rule manager

* fix #10924: fix the regression issue of disable ip filter (#11683)

- unit test is added for RulesDataGrid plugin

* #11678: Fix Manage Rule - WMS service is not reachable (#11679)
@ElenaGallo
Copy link
Copy Markdown
Contributor

ElenaGallo commented Nov 18, 2025

Test passed, @mahmoudadel54 please backport to 2025.02.xx. Thanks

mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this pull request Nov 19, 2025
@mahmoudadel54
geosolutions-it#11678: Fix Manage Rule - WMS service is not reachable (…
2c204e4 
…geosolutions-it#11679)
@mahmoudadel54 mahmoudadel54 mentioned this pull request Nov 19, 2025
Merged
@mahmoudadel54
Copy link
Copy Markdown
Contributor Author

mahmoudadel54 commented Nov 19, 2025

Test passed, @mahmoudadel54 please backport to 2025.02.xx. Thanks

backport is done --> #11699

tdipisa pushed a commit that referenced this pull request Nov 19, 2025
@mahmoudadel54
#11678: Fix Manage Rule - WMS service is not reachable (#11679) (#11699)
d894351
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Nov 19, 2025
allyoucanmap pushed a commit that referenced this pull request Nov 26, 2025
@mahmoudadel54 @allyoucanmap
#11678: Fix Manage Rule - WMS service is not reachable (#11679) (#11699)
468ecc2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@offtherailz offtherailz offtherailz approved these changes

Assignees

@mahmoudadel54 mahmoudadel54

Labels

backport 2025.02.xx bug New SDI Regression

Projects

None yet

Milestone

2025.02.00

Development

Successfully merging this pull request may close these issues.

Manage Rule - WMS service is not reachable

4 participants

@mahmoudadel54 @offtherailz @ElenaGallo @tdipisa