Skip to content

fix 11441 build failure updating cesium 1.133.1#11444

Merged
allyoucanmap merged 1 commit intogeosolutions-it:masterfrom
stefanocudini:11441-fix-build-failure-upgrade-cesium
Sep 9, 2025
Merged

fix 11441 build failure updating cesium 1.133.1#11444
allyoucanmap merged 1 commit intogeosolutions-it:masterfrom
stefanocudini:11441-fix-build-failure-upgrade-cesium

Conversation

@stefanocudini
Copy link
Copy Markdown
Member

@stefanocudini stefanocudini commented Sep 9, 2025 •
edited
Loading

Description

fix #11441 this cesium upgrade prevent build fail:

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

The upgrade from 1.131.0 to 1.133.1
introduce 1 deprecation and 1 potential breaking change which does not concern the current version of MS which does not seem to use this part(ITwinData), Below are the most important references from the Cesium changelog.

## 1.132
Deprecated
Updated all of the ITwinData.* functions to accept an options parameter instead of individual arguments to avoid confusion with multiple optional arguments. There is a fallback to the old signature that will be removed in 1.133 #12778

## 1.133

### Breaking Changes
Removed the argument fallback in ITwinData.* functions. Instead, use the new options argument signature. #12778
https://github.com/CesiumGS/cesium/issues/12778

CesiumGS/cesium#12778

@stefanocudini stefanocudini self-assigned this Sep 9, 2025
@stefanocudini stefanocudini added this to the 2025.02.00 milestone Sep 9, 2025
@stefanocudini stefanocudini added BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch 3D All issues related to the 3D rendering in CesiumJs labels Sep 9, 2025
@stefanocudini stefanocudini changed the title fix 11441 build failure update cesium 1.133.1 fix 11441 build failure updating cesium 1.133.1 Sep 9, 2025
@allyoucanmap allyoucanmap merged commit 40ae620 into geosolutions-it:master Sep 9, 2025
6 checks passed
@allyoucanmap
Copy link
Copy Markdown
Contributor

allyoucanmap commented Sep 9, 2025

@ElenaGallo please test this fix on dev, thanks

dsuren1 added a commit to dsuren1/MapStore2 that referenced this pull request Sep 10, 2025
@dsuren1
Merge commit '84e074585dad7e7622b92d13ac646b0fb1909d4d' into #11387_i…
8d63d07 
…tinerary

* commit '84e074585dad7e7622b92d13ac646b0fb1909d4d':
  Update pom.xml of template to have version  (geosolutions-it#11192)
  Fix geosolutions-it#11441 build failure updating cesium 1.133.1 (geosolutions-it#11444)
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@allyoucanmap allyoucanmap allyoucanmap approved these changes

Assignees

@stefanocudini stefanocudini

Labels

3D All issues related to the 3D rendering in CesiumJs bug

Projects

None yet

Milestone

2025.02.00

Development

Successfully merging this pull request may close these issues.

FE Build failure by cesium

3 participants

@stefanocudini @allyoucanmap @tdipisa