Skip to content

Update pom.xml of template to have version #11192

Merged
MV88 merged 3 commits intomasterfrom
cargo-version
Sep 10, 2025
Merged

Update pom.xml of template to have version #11192
MV88 merged 3 commits intomasterfrom
cargo-version

Conversation

@offtherailz
Copy link
Copy Markdown
Member

Description

This simply avoids the warning

[INFO] Scanning for projects...
[WARNING] 
[WARNING] Some problems were encountered while building the effective model for it.geosolutions.MapStore2-C027:MapStore2-C027-web:war:1.0-SNAPSHOT
[WARNING] 'build.plugins.plugin.version' for org.codehaus.cargo:cargo-maven3-plugin is missing. @ line 410, column 17
[WARNING]
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING]
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
[WARNING]
[INFO] ---------------------------------------------------

When running the backend in dev environment of a project.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe: chore

Issue

What is the current behavior?

no issue

What is the new behavior?

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@offtherailz offtherailz added this to the 2025.02.00 milestone Jun 10, 2025
@offtherailz offtherailz requested a review from MV88 June 10, 2025 15:40
@offtherailz offtherailz self-assigned this Jun 10, 2025
<plugin>
<groupId>org.codehaus.cargo</groupId>
<artifactId>cargo-maven3-plugin</artifactId>
<version>1.10.2</version>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you use a version instead

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also update pom and the other file where this is used product/pom-xml

@tdipisa tdipisa modified the milestones: 2025.02.00, 2025.01.01 Jun 10, 2025
@tdipisa tdipisa added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Jun 10, 2025
Copy link
Copy Markdown
Member

@tdipisa tdipisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@offtherailz let's use variable for dependency versions in root pom.

@offtherailz offtherailz modified the milestones: 2025.01.01, 2025.01.02 Jul 18, 2025
@offtherailz offtherailz requested review from MV88 and tdipisa September 9, 2025 12:32
@offtherailz offtherailz assigned tdipisa and MV88 and unassigned offtherailz Sep 9, 2025
Copy link
Copy Markdown
Member

@tdipisa tdipisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@offtherailz changes seems correct but there are failing checks not related to your changes.
Better anyway to wait until they are resolved.

@offtherailz offtherailz requested a review from tdipisa September 10, 2025 07:42
@offtherailz
Copy link
Copy Markdown
Member Author

@tdipisa fixed

@tdipisa tdipisa requested review from MV88 and removed request for MV88 September 10, 2025 07:49
@MV88 MV88 merged commit 84e0745 into master Sep 10, 2025
6 checks passed
@tdipisa tdipisa deleted the cargo-version branch September 10, 2025 07:52
@tdipisa
Copy link
Copy Markdown
Member

tdipisa commented Sep 10, 2025

@offtherailz please check DEV build and backport. Nothing for @ElenaGallo I suppose here.

@offtherailz
Copy link
Copy Markdown
Member Author

Righ, nothing to test

offtherailz added a commit to offtherailz/MapStore2 that referenced this pull request Sep 10, 2025
* Update pom.xml

* Externalized cargo version
@offtherailz offtherailz removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Sep 10, 2025
dsuren1 added a commit to dsuren1/MapStore2 that referenced this pull request Sep 10, 2025
…tinerary

* commit '84e074585dad7e7622b92d13ac646b0fb1909d4d':
  Update pom.xml of template to have version  (geosolutions-it#11192)
  Fix geosolutions-it#11441 build failure updating cesium 1.133.1 (geosolutions-it#11444)
tdipisa pushed a commit that referenced this pull request Sep 10, 2025
* Update pom.xml

* Externalized cargo version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants