Skip to content

Cannot exit the filter configuration panel during the setup of a widget for dashboards #11269#11287

Merged
tdipisa merged 2 commits intogeosolutions-it:masterfrom
rowheat02:dashboardlayoutstyle
Jul 11, 2025
Merged

Cannot exit the filter configuration panel during the setup of a widget for dashboards #11269#11287
tdipisa merged 2 commits intogeosolutions-it:masterfrom
rowheat02:dashboardlayoutstyle

Conversation

@rowheat02
Copy link
Copy Markdown
Contributor

@rowheat02 rowheat02 commented Jul 4, 2025 •
edited
Loading

Description

On the Dashboard, Query panel and Query Map were overlapping/hiding the brandNavbar. Top position was adjusted for both of them for dashboard

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix

fixes #11269
What is the current behavior?

#11269
What is the new behavior?

  • On the Dashboard page, while performing filter, query panel and map will not overlap/hide brandnavbar.
  • Search icon is changed to tick icon
image

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@rowheat02 rowheat02 added this to the 2025.01.01 milestone Jul 4, 2025
@rowheat02 rowheat02 self-assigned this Jul 4, 2025
@rowheat02 rowheat02 added the bug label Jul 4, 2025
@rowheat02 rowheat02 marked this pull request as ready for review July 4, 2025 15:22
@tdipisa tdipisa requested a review from offtherailz July 4, 2025 15:58
@tdipisa tdipisa added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Jul 4, 2025
offtherailz
offtherailz requested changes Jul 8, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@offtherailz offtherailz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I asked to simplify one thing, moreover I asked @allyoucanmap a sugestion for a better management of layout, if any,

@rowheat02 rowheat02 force-pushed the dashboardlayoutstyle branch from d1cb006 to d4170f9 Compare July 10, 2025 09:33
@rowheat02
Copy link
Copy Markdown
Contributor Author

rowheat02 commented Jul 10, 2025 •
edited
Loading

@offtherailz , @allyoucanmap
As suggested.

  • Added
    #page-dashboard > .ms2-border-layout-body {
        position: relative;
    }
  • default gylp icon to "Ok"
  • The portal is replaced by a create portal
  • targetContainerSelector is configurable in SpatialFilterMap
  • In the query builder, the prop for SpatialFilterMap is passed for targetContainerSelector: "#page-dashboard > .ms2-border-layout-body"
    • If queryselector gets the element, the target container is that element; otherwise, the container that comes from withContainer is the target container
      • updated z-index of mapstore-query-map
image

@tdipisa tdipisa requested review from offtherailz and removed request for offtherailz July 11, 2025 13:15
@allyoucanmap
Copy link
Copy Markdown
Contributor

allyoucanmap commented Jul 11, 2025

@ElenaGallo please test this on dev and let us know when we can backport, thanks

@tdipisa tdipisa merged commit a577f30 into geosolutions-it:master Jul 11, 2025
6 checks passed
@ElenaGallo
Copy link
Copy Markdown
Contributor

ElenaGallo commented Jul 11, 2025

Test passed, @rowheat02 please backport to 2025.01.xx. Thanks

rowheat02 added a commit to rowheat02/MapStore2 that referenced this pull request Jul 14, 2025
@rowheat02
Cannot exit the filter configuration panel during the setup of a widg…
9923fbb 
…et for dashboards geosolutions-it#11269 (geosolutions-it#11287)

* fix: fix dashboard lauyout issue

* fix: ok icon in query builder
@rowheat02 rowheat02 mentioned this pull request Jul 14, 2025
Merged
offtherailz pushed a commit that referenced this pull request Jul 14, 2025
@rowheat02
Cannot exit the filter configuration panel during the setup of a widg…
f93dc2c 
…et for dashboards #11269 (#11287) (#11315)
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@allyoucanmap allyoucanmap allyoucanmap approved these changes

@offtherailz offtherailz Awaiting requested review from offtherailz

Assignees

@rowheat02 rowheat02

Labels

bug

Projects

None yet

Milestone

2025.01.01

Development

Successfully merging this pull request may close these issues.

Cannot exit the filter configuration panel during the setup of a widget for dashboards

5 participants

@rowheat02 @allyoucanmap @ElenaGallo @offtherailz @tdipisa