Skip to content

[#11209]: fix print attribution and duplicate credits issues#11210

Merged
dsuren1 merged 1 commit intogeosolutions-it:masterfrom
congchen1101:fix_print_attribution_duplicate_credits
Jun 17, 2025
Merged

[#11209]: fix print attribution and duplicate credits issues#11210
dsuren1 merged 1 commit intogeosolutions-it:masterfrom
congchen1101:fix_print_attribution_duplicate_credits

Conversation

@congchen1101
Copy link
Copy Markdown
Contributor

fix(print): include attribution in output and remove duplicate credits

  • Added support for including attribution field in print output
  • Avoid duplicate credit entries in printed results
  • Add unit tests for both cases

On behalf of DB Systel GmbH

Description

  • Tests for the changes have been added (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix

Issue

What is the current behavior?
#11209

What is the new behavior?

  1. Copyright information from the attribution field will be printed.
  2. Duplicate copyright entries will be printed only once.

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

fix(print): include attribution in output and remove duplicate credits
- Added support for including attribution field in print output
- Avoid duplicate credit entries in printed results
- Add unit tests for both cases

On behalf of DB Systel GmbH
@congchen1101 congchen1101 changed the title #11209 [#11209]: fix print attribution and duplicate credits issues Jun 16, 2025
@tdipisa tdipisa added this to the 2025.01.01 milestone Jun 16, 2025
@tdipisa tdipisa requested a review from dsuren1 June 16, 2025 12:25
@tdipisa
Copy link
Copy Markdown
Member

tdipisa commented Jun 16, 2025

@congchen1101 thank you for contributing. We will review asap.

@tdipisa tdipisa added BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch labels Jun 16, 2025
@dsuren1 dsuren1 merged commit cf8edb7 into geosolutions-it:master Jun 17, 2025
6 checks passed
@dsuren1
Copy link
Copy Markdown
Contributor

dsuren1 commented Jun 17, 2025

@ElenaGallo Kindly test it in DEV, when available and let's us know if it's good to be backported. Thanks!

@dsuren1 dsuren1 linked an issue Jun 17, 2025 that may be closed by this pull request
1 task
@tdipisa tdipisa modified the milestones: 2025.01.01, 2025.01.02 Jul 11, 2025
@ElenaGallo
Copy link
Copy Markdown
Contributor

ElenaGallo commented Sep 3, 2025

@MV88 test passed, please backport to 2025.01.xx. Thanks

MV88 pushed a commit to MV88/MapStore2 that referenced this pull request Sep 3, 2025
fix(print): include attribution in output and remove duplicate credits
- Added support for including attribution field in print output
- Avoid duplicate credit entries in printed results
- Add unit tests for both cases

On behalf of DB Systel GmbH

Co-authored-by: CongChen <cong.chen.mz@gmail.com>
@MV88
Copy link
Copy Markdown
Contributor

MV88 commented Sep 3, 2025

here is the backport #11428

ElenaGallo pushed a commit that referenced this pull request Sep 3, 2025
fix(print): include attribution in output and remove duplicate credits
- Added support for including attribution field in print output
- Avoid duplicate credit entries in printed results
- Add unit tests for both cases

On behalf of DB Systel GmbH

Co-authored-by: congchen1101 <161452326+congchen1101@users.noreply.github.com>
Co-authored-by: CongChen <cong.chen.mz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch bug External Contribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Print Output Issues with Attribution and Duplicate Credits in MapStore

7 participants