Skip to content

backport c027-2024.01.xx - Fix #10966 basic auth for services (#11067)#11070

Merged
allyoucanmap merged 11 commits intogeosolutions-it:c027-2024.01.xxfrom
MV88:c027_10966
May 13, 2025
Merged

backport c027-2024.01.xx - Fix #10966 basic auth for services (#11067)#11070
allyoucanmap merged 11 commits intogeosolutions-it:c027-2024.01.xxfrom
MV88:c027_10966

Conversation

@MV88
Copy link
Copy Markdown
Contributor

@MV88 MV88 commented May 5, 2025

Description

backport c027-2024.01.xx - Fix #10966 basic auth for services (#11067)

)

* # This is a combination of 2 commits.

Fix geosolutions-it#10966 basic auth for services

Wip

* Fix geosolutions-it#10966 basic auth for services

* update config

* fix jsdoc

* fix jsdoc

* fix tests

* update review

* clean up

* fix tests

* Update web/client/plugins/MetadataExplorer.jsx

Co-authored-by: stefano bovio <stefano.bovio@geosolutionsgroup.com>

* Update web/client/plugins/MetadataExplorer.jsx

Co-authored-by: stefano bovio <stefano.bovio@geosolutionsgroup.com>

---------

Co-authored-by: stefano bovio <stefano.bovio@geosolutionsgroup.com>
@MV88 MV88 added the Backport label May 5, 2025
@MV88 MV88 added this to the 2025.02.00 milestone May 5, 2025
@MV88 MV88 requested a review from allyoucanmap May 5, 2025 16:03
@MV88 MV88 self-assigned this May 5, 2025
MV88 and others added 5 commits May 6, 2025 17:16
…utions-it#11077)

* Fix geosolutions-it#10966 improved basic auth modal and logic

* fix tests

* created getAuthorizationBasic to harmonize code and tests
…modal (geosolutions-it#11082)

* fix geosolutions-it#10966 some inconsistencies on the security popup modal

* review changes (#7)

* fix an error in widgets state

* update tests

* fix test and animation

* fix test

---------

Co-authored-by: stefano bovio <stefano.bovio@geosolutionsgroup.com>

import React from 'react';
import { FormControl as FormControlRB } from 'react-bootstrap';
import withDebounceOnCallback from '../../../components/misc/enhancers/withDebounceOnCallback';
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file can be removed it's not used

);
}

export default ConfirmDialog;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file can be removed it's not used

import localizedProps from '../../misc/enhancers/localizedProps';
import {defaultPlaceholder, isValidURL} from "./MainFormUtils";

import IconRB from '../../../plugins/ResourcesCatalog/components/Icon';
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case it's better to use directly Glyphicon so we can remove Icon from this PR

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a custom branch where we backport that feature, i would prefer to avoid to have too many differences from the master branch. i would skip this

name,
className,
style
}) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this component if we use Glyphicon instead in the other files. Then we can remove the ResourcesCatalog folder

const FlexBox = forwardRef(({
children,
className,
classNames = [],
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing less file with css rules

* @prop {string} className custom class name
* @prop {object} style custom style object
*/
function Spinner({
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing less file with css rules

* @prop {string} textAlign one of `left`, `right` or `center`
* @prop {bool} strong if true it applies strong style
*/
const Text = ({
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing less file with css rules

borderTransparent,
...props
}, ref) => {
return (
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing less file with css rules

@tdipisa tdipisa requested a review from allyoucanmap May 12, 2025 09:17
Comment on lines +4 to +15
@import "_base.less";
@import "_brand-navbar.less";
@import "_details-panel.less";
@import "_footer.less";
@import "_home-description.less";
@import "_permissions.less";
@import "_resource-card.less";
@import "_resources-container.less";
@import "_resources-panel-wrapper.less";
@import "_resources-search.less";
@import "_spinner.less";
@import "_tags-manager.less";
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Currently the style is not applied because this file is not imported in the main mapstore.less theme.
Please include only what's needed that should be inside spinner.less and utility.less (please double check this)

@tdipisa tdipisa linked an issue May 12, 2025 that may be closed by this pull request
10 tasks
@MV88 MV88 requested a review from allyoucanmap May 13, 2025 09:40
@allyoucanmap allyoucanmap merged commit 51ca3d0 into geosolutions-it:c027-2024.01.xx May 13, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Insert credentials at runtime when connecting to secured services

3 participants