Skip to content

Fix #10966 adding securityPopup in other catalogs#11083

Merged
allyoucanmap merged 2 commits intogeosolutions-it:masterfrom
MV88:10966_creds_part4
May 9, 2025
Merged

Fix #10966 adding securityPopup in other catalogs#11083
allyoucanmap merged 2 commits intogeosolutions-it:masterfrom
MV88:10966_creds_part4

Conversation

@MV88
Copy link
Copy Markdown
Contributor

@MV88 MV88 commented May 8, 2025 •
edited
Loading

Description

  • avoiding to show modal if no protected layers are present
  • adding security popup in
    • dashboard editor
    • context editor
    • map editor in geostory
  • if no credentials are present in the sessionStorage if you click the search button it will open the security modal popup

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?

fix #10966

What is the new behavior?

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@MV88 MV88 added this to the 2025.02.00 milestone May 8, 2025
@MV88 MV88 requested a review from allyoucanmap May 8, 2025 19:49
@MV88 MV88 self-assigned this May 8, 2025
@MV88 MV88 added the New Feature used for new functionalities label May 9, 2025
@tdipisa tdipisa linked an issue May 9, 2025 that may be closed by this pull request
Insert credentials at runtime when connecting to secured services #10966
Closed
10 tasks
allyoucanmap
allyoucanmap requested changes May 9, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@allyoucanmap allyoucanmap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The security popup is not visible inside the geostory map editor probably due to z-index:

geostory-security-popup.mp4

@MV88
Copy link
Copy Markdown
Contributor Author

MV88 commented May 9, 2025

The security popup is not visible inside the geostory map editor probably due to z-index:

geostory-security-popup.mp4

fixed in next commit
image

@MV88 MV88 requested a review from allyoucanmap May 9, 2025 12:37
@allyoucanmap allyoucanmap merged commit dc27d2d into geosolutions-it:master May 9, 2025
6 checks passed
@allyoucanmap
Copy link
Copy Markdown
Contributor

allyoucanmap commented May 9, 2025 •
edited
Loading

@ElenaGallo please test this fix on dev, thanks

MV88 added a commit to MV88/MapStore2 that referenced this pull request May 9, 2025
@MV88
Fix geosolutions-it#10966 adding securityPopup in other catalogs (geo…
59a7b69 
…solutions-it#11083)
@ElenaGallo
Copy link
Copy Markdown
Contributor

ElenaGallo commented May 9, 2025

@MV88 @tdipisa please check my points below:

The 4th and 5th point are still present:
4_ If I enter incorrect credentials and confirm, the pop-up closes and the button turns green, giving the impression that the service was added successfully.

4.mp4

5 _ If I add a service that requires authentication (e.g., https://gs-stable.geo-solutions.it/geoserver/basic/wms), it is possible to add a layer even without entering credentials.

5.mp4

@MV88
Copy link
Copy Markdown
Contributor Author

MV88 commented May 9, 2025 •
edited
Loading

point 4 and 5 and the following which is similar

When I open a resource with Basic Auth set, if incorrect credentials are entered in the modal, no warning or error message appears.

will not be addressed now

checking first point

When I open a context with Basic Auth set, credentials are not requested and the layer is not visible on the map.
Try with this context: https://dev-mapstore.geosolutionsgroup.com/mapstore/#/context/basic_context

@MV88 MV88 mentioned this pull request May 9, 2025
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@allyoucanmap allyoucanmap allyoucanmap approved these changes

Assignees

@MV88 MV88

Labels

New Feature used for new functionalities

Projects

None yet

Milestone

2025.02.00

Development

Successfully merging this pull request may close these issues.

Insert credentials at runtime when connecting to secured services

3 participants

@MV88 @allyoucanmap @ElenaGallo