fix #10966 some inconsistencies on the security popup modal#11082
fix #10966 some inconsistencies on the security popup modal#11082MV88 merged 6 commits intogeosolutions-it:masterfrom
Conversation
web/client/plugins/SecurityPopup.jsx
Outdated
| const credentials = getCredentials(id); | ||
| setCreds(credentials); | ||
| }, [id, currentFormIndex]); | ||
| useEffect(() => { | ||
| const credentials = getCredentials(id); | ||
| setCreds(credentials); | ||
| return () => { | ||
| setCreds({}); | ||
| }; | ||
| }, []); |
There was a problem hiding this comment.
I tested locally and I found this issue, where the form is empty after saving:
security-empty.mp4
Here I opened a PR with a proposal to change the management of credential directly inside the popup to take advantage of mount unmount event triggered by the key prop MV88#7
Please double check if the changes included in the PR works as expected
There was a problem hiding this comment.
I tested locally and I found this issue, where the form is empty after saving:
security-empty.mp4
Here I opened a PR with a proposal to change the management of credential directly inside the popup to take advantage of mount unmount event triggered by the key prop MV88#7Please double check if the changes included in the PR works as expected
i fixed also tests. you can review again
…modal (geosolutions-it#11082) * fix geosolutions-it#10966 some inconsistencies on the security popup modal * review changes (#7) * fix an error in widgets state * update tests * fix test and animation * fix test --------- Co-authored-by: stefano bovio <stefano.bovio@geosolutionsgroup.com>
Description
fix #10966 some inconsistencies on the security popup modal
The form sometimes were not correctly populated when opening
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#10966
What is the new behavior?
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information