#10622: Fix Not possible to remove widget from Map - JavaScript error#10623
Merged
MV88 merged 1 commit intogeosolutions-it:masterfrom Oct 24, 2024
Merged
#10622: Fix Not possible to remove widget from Map - JavaScript error#10623MV88 merged 1 commit intogeosolutions-it:masterfrom
MV88 merged 1 commit intogeosolutions-it:masterfrom
Conversation
…cript error Description: - fix the issue of not remove widget from map in case of existing other widgets has dependenciesMap prop = empty object - add unit test
1 task
Contributor
|
@ElenaGallo pls test it in DEV |
Contributor
|
Test passed, @mahmoudadel54 please backport to 2024.02.xx. Thanks |
Member
@mahmoudadel54 the PR need to be also backported to c027-2024-10-24 branch. Thank you. |
mahmoudadel54
added a commit
to mahmoudadel54/MapStore2
that referenced
this pull request
Oct 25, 2024
…cript error (geosolutions-it#10623) Description: - fix the issue of not remove widget from map in case of existing other widgets has dependenciesMap prop = empty object - add unit test
mahmoudadel54
added a commit
to mahmoudadel54/MapStore2
that referenced
this pull request
Oct 25, 2024
…cript error (geosolutions-it#10623) Description: - fix the issue of not remove widget from map in case of existing other widgets has dependenciesMap prop = empty object - add unit test
Contributor
Author
Backport is done ---> #10629 |
MV88
pushed a commit
that referenced
this pull request
Oct 25, 2024
Contributor
Author
Backport is done ---> #10630 |
rmelarab-ngs
pushed a commit
to ngsllc/MapStore2
that referenced
this pull request
Nov 5, 2024
…cript error (geosolutions-it#10623) Description: - fix the issue of not remove widget from map in case of existing other widgets has dependenciesMap prop = empty object - add unit test
MV88
added a commit
that referenced
this pull request
Nov 6, 2024
…om Map - JavaScript error (#10623) (#10630) * #10622: Not possible to remove widget from Map - JavaScript error (#10623) Description: - fix the issue of not remove widget from map in case of existing other widgets has dependenciesMap prop = empty object - add unit test * tentative fix for the test --------- Co-authored-by: MV88 <matteo.velludini@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue of not remove widget from map in case of existing other widgets has dependenciesMap prop = empty object.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
#10622
What is the current behavior?
#10622
What is the new behavior?
The delete confirmation dialog window closes and the widget is removed from the map normally.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information