[Backport c027-2024-10-24] - #10622: Not possible to remove widget from Map - JavaScript error (#10623)#10630
Merged
MV88 merged 4 commits intogeosolutions-it:c027-2024-10-24from Nov 6, 2024
Conversation
…cript error (geosolutions-it#10623) Description: - fix the issue of not remove widget from map in case of existing other widgets has dependenciesMap prop = empty object - add unit test
1 task
12 tasks
tdipisa
requested changes
Oct 25, 2024
Member
tdipisa
left a comment
There was a problem hiding this comment.
@mahmoudadel54 it seems there is a failing check. Can you please have a look?
…l54/MapStore2 into mahmoudadel54-porting_10622_c027-2024-10-24
Tentative fix test
MV88
approved these changes
Nov 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is backport PR:
[Backport c027-2024-10-24] - #10622 : Not possible to remove widget from Map - JavaScript error (#10623)