Conversation
refactoring the DropdownButton component to use FloatingUI, and ensuring the size of the dropdown "menu" (aka the floating thing) can't grow outside the document's height, and switch to a scroll/overflow if needed
stop the propagation of click event on items, after they are caught by the dropdown button component. This way the parent floatingUI window doesn't receive the click event, and is not closing because of it.
and raise up a notch the seed/upper limit for random ID on Dropdown, to reduce even more the chance to get twice the same number on subsequent uses (and have twice the same HTML ID in the app)
Issue: We currently don't have any unsolved issue, but using the service-worker tends to break api calls, as it already happened with the QRCode and the Print. Fix: To be on the safe side, we extend the deny list to all API calls, excluding them from the caching system.
Issue: When embedding an iframe with a legacy link, the service worker stops the redirection `hack` that allows us to have a clean embed route at the end, and so the legacy embed link is treated as a map link Fix: no service-worker for legacy embed links
…ker-deny-list PB-1823: Extend the Service Worker deny list to all API calls
Issue: the terms of use link in the iframe integration menu, in english, returns a 404 since the page doesn't exist Fix: We link to the german one.
thanks to @bariod for finding them :)
…-of-use-link PB-1872: term of use in english iframe menu returns a 404
so that we may see our DEV/INT deployment preview without needing to clear any cache
Issue: When people click on the "delete" button in drawing, and confirm it by clicking 'OK', they realize afterwards that they decided to delete all their work and sometimes ask us to retrieve their lost data. Fix: We are now more explicit about what we're deleting, and the modal message now clearly says "Delete Everything". We Also added the code that would allow us to add custom confirm / cancel messages and icons for every modal we use.
…-easier-to-understand PB-1866: Make delete drawing window easier to understand
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 06m 08s |
| Commit |
|
| Committer | Pascal Barth |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
20
|
|
|
0
|
|
|
260
|
| View all changes introduced in this branch ↗︎ | |
sommerfe
approved these changes
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test link