Skip to content

New Release v1.59.0 - #minor#1391

Merged
pakb merged 16 commits intomasterfrom
develop
Aug 6, 2025
Merged

New Release v1.59.0 - #minor#1391
pakb merged 16 commits intomasterfrom
develop

Conversation

@pakb
Copy link
Contributor

@pakb pakb commented Aug 6, 2025

pakb and others added 16 commits August 4, 2025 11:46
refactoring the DropdownButton component to use FloatingUI, and ensuring the size of the dropdown "menu" (aka the floating thing) can't grow outside the document's height, and switch to a scroll/overflow if needed
stop the propagation of click event on items, after they are caught by the dropdown button component. This way the parent floatingUI window doesn't receive the click event, and is not closing because of it.
and raise up a notch the seed/upper limit for random ID on Dropdown, to reduce even more the chance to get twice the same number on subsequent uses (and have twice the same HTML ID in the app)
Issue: We currently don't have any unsolved issue, but using the service-worker tends to break api calls, as it already happened with the QRCode and the Print.

Fix: To be on the safe side, we extend the deny list to all API calls, excluding them from the caching system.
Issue: When embedding an iframe with a legacy link, the service worker stops the redirection `hack` that allows us to have a clean embed route at the end, and so the legacy embed link is treated as a map link

Fix: no service-worker for legacy embed links
Issue: the terms of use link in the iframe integration menu, in english, returns a 404 since the page doesn't exist

Fix: We link to the german one.
thanks to @bariod for finding them :)
so that we may see our DEV/INT deployment preview without needing to clear any cache
…ache

PB-1823: also ignore preview sites from ServiceWorker cache
Issue: When people click on the "delete" button in drawing, and confirm it by clicking 'OK', they realize afterwards that they decided to delete all their work and sometimes ask us to retrieve their lost data.

Fix: We are now more explicit about what we're deleting, and the modal message now clearly says "Delete Everything". We Also added the code that would allow us to add custom confirm / cancel messages and icons for every modal we use.
@github-actions github-actions bot changed the title new version New Release v1.59.0 - #minor Aug 6, 2025
@cypress
Copy link

cypress bot commented Aug 6, 2025

web-mapviewer    Run #5557

Run Properties:  status check passed Passed #5557  •  git commit 3e5a290053: Merge pull request #1389 from geoadmin/feat-PB-1866-make-delete-modal-easier-to-...
Project web-mapviewer
Branch Review develop
Run status status check passed Passed #5557
Run duration 06m 08s
Commit git commit 3e5a290053: Merge pull request #1389 from geoadmin/feat-PB-1866-make-delete-modal-easier-to-...
Committer Pascal Barth
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 20
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 260
View all changes introduced in this branch ↗︎

@pakb pakb requested review from ltkum, schtibe and sommerfe August 6, 2025 06:19
@pakb pakb merged commit d78327e into master Aug 6, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants