PB-1823: Extend the Service Worker deny list to all API calls#1387
Merged
PB-1823: Extend the Service Worker deny list to all API calls#1387
Conversation
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
fix-PB-1823-extend-service-worker-deny-list
|
| Run status |
|
| Run duration | 04m 44s |
| Commit |
|
| Committer | Martin Künzi |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
20
|
Skipped
|
0
|
Passing
|
260
|
| View all changes introduced in this branch ↗︎ | |
f1de23b to
1a45ef9
Compare
pakb
reviewed
Aug 4, 2025
30d6560 to
dac29ee
Compare
dac29ee to
371524a
Compare
Issue: We currently don't have any unsolved issue, but using the service-worker tends to break api calls, as it already happened with the QRCode and the Print. Fix: To be on the safe side, we extend the deny list to all API calls, excluding them from the caching system.
Issue: When embedding an iframe with a legacy link, the service worker stops the redirection `hack` that allows us to have a clean embed route at the end, and so the legacy embed link is treated as a map link Fix: no service-worker for legacy embed links
371524a to
2e0f8d7
Compare
pakb
approved these changes
Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: We currently don't have any unsolved issue, but using the service-worker tends to break api calls, as it already happened with the QRCode and the Print.
Fix: To be on the safe side, we extend the deny list to all API calls, excluding them from the caching system.
Test link