PB-1872: term of use in english iframe menu returns a 404#1388
Merged
PB-1872: term of use in english iframe menu returns a 404#1388
Conversation
web-mapviewer
|
||||||||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
fix-PB-1872-change-iframe-term-of-use-link
|
| Run status |
|
| Run duration | 06m 04s |
| Commit |
|
| Committer | Martin Künzi |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
0
|
Pending
|
20
|
Skipped
|
0
|
Passing
|
253
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
tests/cypress/tests-e2e/importToolFile.cy.js • 1 failed test • e2e/chrome/mobile
| Test | Artifacts | |
|---|---|---|
| The Import File Tool > Import GPX file |
Test Replay
Screenshots
|
|
pakb
approved these changes
Aug 5, 2025
Issue: the terms of use link in the iframe integration menu, in english, returns a 404 since the page doesn't exist Fix: We link to the german one.
9bc58b7 to
aee8e7a
Compare
thanks to @bariod for finding them :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: the terms of use link in the iframe integration menu, in english, returns a 404 since the page doesn't exist
Fix: We link to the german one.
Test link