Skip to content

New Release v1.51.0 - #minor#1207

Merged
pakb merged 114 commits intomasterfrom
develop
Jan 20, 2025
Merged

New Release v1.51.0 - #minor#1207
pakb merged 114 commits intomasterfrom
develop

Conversation

@pakb
Copy link
Contributor

@pakb pakb commented Jan 17, 2025

pakb and others added 30 commits December 17, 2024 12:36
block typescript update to v5.6.3, going further is not compatible with vue-tsc at the moment (see vuejs/language-tools#4484 )

issue with flickering label in Cesium has been fixed with latest release, we can go back to using the latest version in our dependecies
…file

PB-1216: Add warning on sharing when there is a local files.
Issue: The compass in the 3d viewer was hidden

Cause: We checked before there was an instance of the component if we could add the scene and the clock to the compass element, meaning it would create an empty compass.

Fix: We wait for the map to be ready before adding the compass
ismailsunni and others added 23 commits January 14, 2025 11:29
…-is-hidden

PB-400: Add test for hiding the dropdown adter selecting a search result
…rnally.

This involves translating the title in the getter, such that when called, it is
up-to-date with the current language context in web-mapviewer.
instead of failing and raising an error while using t(...), vue-i18n now gives back the "key" or text it received unchanged. This way we can call translation tool on input from other component without worrying on raising errors.

The DropdownButton now translates anything it receives, making it possible to give it either keys, or translated text directly.

Removing the class DropdownItem and replacing it with a typedef instead. We now know that passing classes with get/set to Vuex is a bad practice, and we should avoid it.
Adapted the cypress tests to the new drop down item values.
so that it uses aliases on element whenever possible, and also test the payload of feedback for the category too.
…tion-issue

PB-1327: Refactored 'DropdownItem' to translate the button title internally
to fix the issue with label flickering.

Also updating all other libs in the process.
I had to delete and recreate the package-lock.json for things to work properly (related to migration to Node22 maybe?)
Issue: We want the users to understand what each category is used for in the feedback form.

Fix: We add a link under the category selection that leads to the news about the categories. In the near future, we'll change the link to the help page itself.
there are from time to time console.log (or console.error) that slips through our review process.
To counter that I've activated the ESLint no-console rule on all non-test, non-script files.
@github-actions github-actions bot changed the title new release New Release v1.51.0 - #minor Jan 17, 2025
Copy link
Contributor

@ltkum ltkum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there might still be console logs somewhere, we can find them later :)

@pakb pakb merged commit ce8e886 into master Jan 20, 2025
4 checks passed
@cypress
Copy link

cypress bot commented Jan 20, 2025

web-mapviewer    Run #4324

Run Properties:  status check passed Passed #4324  •  git commit ce8e886683: Merge pull request #1207 from geoadmin/develop
Project web-mapviewer
Branch Review master
Run status status check passed Passed #4324
Run duration 01m 47s
Commit git commit ce8e886683: Merge pull request #1207 from geoadmin/develop
Committer Pascal Barth
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 1
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 48
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants