PB-1216: Add warning on sharing when there is a local files.#1136
Merged
ismailsunni merged 18 commits intodevelopfrom Dec 18, 2024
Merged
PB-1216: Add warning on sharing when there is a local files.#1136ismailsunni merged 18 commits intodevelopfrom
ismailsunni merged 18 commits intodevelopfrom
Conversation
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 01m 45s |
| Commit |
|
| Committer | Ismail Sunni |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
1
|
Skipped
|
0
|
Passing
|
48
|
| View all changes introduced in this branch ↗︎ | |
pakb
reviewed
Nov 27, 2024
Contributor
pakb
left a comment
There was a problem hiding this comment.
I think it would make more sense to have the "Share link input" and its button with this yellow-ish color, and a tooltip that shows when we hover it stating what you've added in the warning message.
Having a warning message popping up each time you open the share section is not ideal and not comfortable for users IMO
Contributor
|
|
3532dd4 to
1f7f57f
Compare
Contributor
Author
|
@pakb here is updated style for the warning. |
51246cd to
898cb5c
Compare
pakb
reviewed
Dec 11, 2024
1a0229a to
9e24b45
Compare
pakb
approved these changes
Dec 17, 2024
9e24b45 to
f379ff1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let me know if there is suggestion for the warning text.
Test link