Skip to content

PB-400: Add test for hiding the dropdown adter selecting a search result#1194

Merged
ismailsunni merged 2 commits intodevelopfrom
feat-pb-400-test-search-result-is-hidden
Jan 14, 2025
Merged

PB-400: Add test for hiding the dropdown adter selecting a search result#1194
ismailsunni merged 2 commits intodevelopfrom
feat-pb-400-test-search-result-is-hidden

Conversation

@ismailsunni
Copy link
Contributor

@ismailsunni ismailsunni commented Jan 13, 2025

@ismailsunni ismailsunni force-pushed the feat-pb-400-test-search-result-is-hidden branch from dbb9f90 to 9d94d23 Compare January 13, 2025 10:10
@cypress
Copy link

cypress bot commented Jan 13, 2025

web-mapviewer    Run #4271

Run Properties:  status check passed Passed #4271  •  git commit 43cd93c208: Merge pull request #1194 from geoadmin/feat-pb-400-test-search-result-is-hidden
Project web-mapviewer
Branch Review develop
Run status status check passed Passed #4271
Run duration 01m 43s
Commit git commit 43cd93c208: Merge pull request #1194 from geoadmin/feat-pb-400-test-search-result-is-hidden
Committer Ismail Sunni
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 1
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 48
View all changes introduced in this branch ↗︎

Copy link
Contributor

@ltkum ltkum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change one thing, but as this is only adding a log and removing a comment, I don't want you to be blocked by having to wait for another review.

@ismailsunni ismailsunni force-pushed the feat-pb-400-test-search-result-is-hidden branch from 9d94d23 to d003f79 Compare January 14, 2025 04:31
@ismailsunni ismailsunni merged commit 43cd93c into develop Jan 14, 2025
3 checks passed
@ismailsunni ismailsunni deleted the feat-pb-400-test-search-result-is-hidden branch January 14, 2025 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants