Conversation
Add a debug tool to help us find relevant layers
PB-774: Reset to default background layer when clicking on the logo
Issue: In chrome-based web browsers, the layers would be removed from the preview and the link when opening the embed preview unless the bgLayer was 'void'. Cause: There might be a need to refactor completely the embed sharing component, but for now, it seems the issue was caused by the bgLayer parameter being handled before the layers. This would cause a situation where the router would trigger a mutation, go to a new URL with no layers, and overwrite what should have been in store. As the default background layer is the void one, we did not go through this when we used the empty background layer. Fix: by changing the order in which the parameters are handled, we can ensure layers are handled before the background layer, and thus ensure they are kept.
Issue : the tests for the embed links checked strings as they are without any further processing. This meant that if the order of the parameters changed, it would make the test fail. Fix : We update the tests with a deep comparison between two 'URLSearchParams' made from the variable parameter and the validation string
PB-1181: menu scrollable
…d vertex button overlay
…t-on-editing-mode PB-1212: Allow delete last point by button when on line editing mode.
users were confused that the full address of what they selected in the search result wasn't properly shown in the UI. This only adds the title of such entries to the search bar, without triggering a new search. This means the search results aren't cleared/emptied when a location is selected.
PB-1246 : add location search entry title to search bar when selected
During the build the cesium static assets were put into the root of the application. This was an issue for our deployment strategy were we have all assets in a versioned folder and were we first deploy the versioned folder before deploying the entry point index.html that point to the versioned folder. This allow for a pseudo atomic deployment. So now all the cesium static assets have been placed into VERSION/cesium/ path.
PB-1176: Fix cesium static assets location
Issue : When activating geolocation for the first time, we do not zoom on the location Fix : We use the already existing boolean to check if we're on the geolocation first activation. If that's the case, we now zoom at zoom level 8
…eolocation PB-1146: Zoom in on geolocation first activation
PB-1190: print feature
instead of having hard-coded values. This means we can now show the next year's data point without waiting for the 1st of January, and also show older data than the arbitrarily chosen limit of 1844.
fixing an issue with preview layer being kept on the map after added through the catalogue component
don't know why this pops up on this PR which doesn't change anything in the import KML, but I've added the necessary intercepts on the search made while importing a KML to fix the flakyness of this test. Was certainly due to some race condition on the real search service responding faster than expected, we should not use the real service for such tests anyway...
and add some perf improvements flags for when the CI runs tests heedlessly
with the same logic/approach that we had with the OpenLayers counterpart, leaving only the responsibility to create and share the Cesium instance to the main component, and giving all others (interactions, layer management, feature highlighting) to sub-components.
…component PB-1204 : split CesiumMap component into multiple sub-parts
PB-1295 : add drag&drop support for 3D viewer
In order to simplify the CD Pipeline put the different build output based on the same staging names that we have aka; dev, int and prod. Also added more information to the info.json file that will be used as Pipeline trigger. Changed the info.json generator to make full use of nodejs async functionality.
PB-1176: Prepare build output for CD Pipeline
ltshb
approved these changes
Dec 17, 2024
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
master
|
| Run status |
|
| Run duration | 05m 06s |
| Commit |
|
| Committer | Pascal Barth |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
21
|
|
|
0
|
|
|
216
|
| View all changes introduced in this branch ↗︎ | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test link