Skip to content

New Release v1.50.0 - #minor#1175

Merged
pakb merged 43 commits intomasterfrom
develop
Dec 17, 2024
Merged

New Release v1.50.0 - #minor#1175
pakb merged 43 commits intomasterfrom
develop

Conversation

@pakb
Copy link
Contributor

@pakb pakb commented Dec 17, 2024

pakb and others added 30 commits December 3, 2024 08:40
Add a debug tool to help us find relevant layers
PB-774: Reset to default background layer when clicking on the logo
Issue: In chrome-based web browsers, the layers would be removed from the preview and the link when opening the embed preview unless the bgLayer was 'void'.

Cause: There might be a need to refactor completely the embed sharing component, but for now, it seems the issue was caused by the bgLayer parameter being handled before the layers.
This would cause a situation where the router would trigger a mutation, go to a new URL with no layers, and overwrite what should have been in store. As the default background layer is the void one, we did not go through this when we used the empty background layer.

Fix: by changing the order in which the parameters are handled, we can ensure layers are handled before the background layer, and thus ensure they are kept.
Issue : the tests for the embed links checked strings as they are without any further processing. This meant that if the order of the parameters changed, it would make the test fail.

Fix : We update the tests with a deep comparison between two 'URLSearchParams' made from the variable parameter and the validation string
…t-on-editing-mode

PB-1212: Allow delete last point by button when on line editing mode.
users were confused that the full address of what they selected in the search result wasn't properly shown in the UI.

This only adds the title of such entries to the search bar, without triggering a new search. This means the search results aren't cleared/emptied when a location is selected.
PB-1246 : add location search entry title to search bar when selected
During the build the cesium static assets were put into the root of the application.
This was an issue for our deployment strategy were we have all assets in a
versioned folder and were we first deploy the versioned folder before deploying
the entry point index.html that point to the versioned folder. This allow for
a pseudo atomic deployment.

So now all the cesium static assets have been placed into VERSION/cesium/ path.
Issue : When activating geolocation for the first time, we do not zoom on the location

Fix : We use the already existing boolean to check if we're on the geolocation first activation. If that's the case, we now zoom at zoom level 8
instead of having hard-coded values. This means we can now show the next year's data point without waiting for the 1st of January, and also show older data than the arbitrarily chosen limit of 1844.
pakb and others added 13 commits December 12, 2024 09:08
…slider

PB-1290 : read time slider oldest/youngest year from layers config
fixing an issue with preview layer being kept on the map after added through the catalogue component
don't know why this pops up on this PR which doesn't change anything in the import KML, but I've added the necessary intercepts on the search made while importing a KML to fix the flakyness of this test.
Was certainly due to some race condition on the real search service responding faster than expected, we should not use the real service for such tests anyway...
and add some perf improvements flags for when the CI runs tests heedlessly
with the same logic/approach that we had with the OpenLayers counterpart, leaving only the responsibility to create and share the Cesium instance to the main component, and giving all others (interactions, layer management, feature highlighting) to sub-components.
In order to simplify the CD Pipeline put the different build output based on the
same staging names that we have aka; dev, int and prod.

Also added more information to the info.json file that will be used as Pipeline
trigger.

Changed the info.json generator to make full use of nodejs async functionality.
@github-actions github-actions bot changed the title new version New Release v1.50.0 - #minor Dec 17, 2024
@pakb pakb requested a review from ltshb December 17, 2024 08:22
@pakb pakb merged commit d6bc2e0 into master Dec 17, 2024
@cypress
Copy link

cypress bot commented Dec 17, 2024

web-mapviewer    Run #4306

Run Properties:  status check passed Passed #4306  •  git commit d6bc2e0531: Merge pull request #1175 from geoadmin/develop
Project web-mapviewer
Branch Review master
Run status status check passed Passed #4306
Run duration 05m 06s
Commit git commit d6bc2e0531: Merge pull request #1175 from geoadmin/develop
Committer Pascal Barth
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 21
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 216
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants