PB-1290 : read time slider oldest/youngest year from layers config#1168
Merged
PB-1290 : read time slider oldest/youngest year from layers config#1168
Conversation
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
bug-PB-1290-next-year-in-time-slider
|
| Run status |
|
| Run duration | 05m 11s |
| Commit |
|
| Committer | Pascal Barth |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
21
|
Skipped
|
0
|
Passing
|
216
|
| View all changes introduced in this branch ↗︎ | |
instead of having hard-coded values. This means we can now show the next year's data point without waiting for the 1st of January, and also show older data than the arbitrarily chosen limit of 1844.
c9802ea to
fe5cb2a
Compare
ltkum
approved these changes
Dec 12, 2024
Contributor
ltkum
left a comment
There was a problem hiding this comment.
I got a brain freeze for a bit as I mistook oldest and youngest time for a few moments, but when I came to my senses, I couldn't find any fault within the code. :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
instead of having hard-coded values. This means we can now show the next year's data point without waiting for the 1st of January, and also show older data than the arbitrarily chosen limit of 1844.
Test link