Skip to content

PB-774: Reset to default background layer when clicking on the logo#1135

Merged
ismailsunni merged 3 commits intodevelopfrom
pb-774-do-not-reset-bg-layer
Dec 3, 2024
Merged

PB-774: Reset to default background layer when clicking on the logo#1135
ismailsunni merged 3 commits intodevelopfrom
pb-774-do-not-reset-bg-layer

Conversation

@ismailsunni
Copy link
Contributor

@ismailsunni ismailsunni commented Nov 25, 2024

@cypress
Copy link

cypress bot commented Nov 25, 2024

web-mapviewer    Run #3983

Run Properties:  status check passed Passed #3983  •  git commit 6484b5e39c: PB-774: Add test for using default bg layer.
Project web-mapviewer
Branch Review pb-774-do-not-reset-bg-layer
Run status status check passed Passed #3983
Run duration 04m 07s
Commit git commit 6484b5e39c: PB-774: Add test for using default bg layer.
Committer Ismail Sunni
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 21
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 214
View all changes introduced in this branch ↗︎

@ismailsunni ismailsunni requested a review from pakb November 25, 2024 09:26
@ismailsunni ismailsunni force-pushed the pb-774-do-not-reset-bg-layer branch from c9f32fb to ba8e2c8 Compare November 28, 2024 04:26
@ismailsunni ismailsunni requested a review from pakb November 28, 2024 04:28
Copy link
Contributor

@pakb pakb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a relevant Cypress test for that? So that we make sure we do not regress on this later on 😉

@ismailsunni ismailsunni force-pushed the pb-774-do-not-reset-bg-layer branch from ba8e2c8 to 44a7e7d Compare December 2, 2024 08:31
@ismailsunni ismailsunni requested a review from pakb December 2, 2024 08:43
@ismailsunni
Copy link
Contributor Author

@pakb test added

@ismailsunni ismailsunni force-pushed the pb-774-do-not-reset-bg-layer branch from 44a7e7d to 6484b5e Compare December 3, 2024 11:45
@ismailsunni ismailsunni merged commit 7356671 into develop Dec 3, 2024
@ismailsunni ismailsunni deleted the pb-774-do-not-reset-bg-layer branch December 3, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants