Skip to content

New Release v1.49.2 - #patch#1152

Merged
pakb merged 9 commits intomasterfrom
develop
Dec 2, 2024
Merged

New Release v1.49.2 - #patch#1152
pakb merged 9 commits intomasterfrom
develop

Conversation

@pakb
Copy link
Contributor

@pakb pakb commented Dec 2, 2024

sommerfe and others added 9 commits November 27, 2024 11:38
transform the Cesium WMTS component to composition API

Adding a composable that can be used for WMS layers when we want to move them to composition API too.

Issues fixed by this commit :
- opacity when a layer as a specific config for 3D (like SWISSIMAGE) by giving the 3D config the same opacity as the 2D equivalent.
The opacity of the 3D config was used, but the UI is editing the opacity of the 2D layer.
- error that popped up in the console when switching from 3D to 2D, the camera position is set to null by the unmounted CesiumMap hook and then the sync camera plugin uses the camera value without checking its validity. Adding a little check to remove the error
- External WMTS style wasn't properly applied to the 3D viewer, a good example is to load swissdatacube WMTS with layer diff_all_CH, as its default style isn't named "default" but something else
Issue: when the application was already loaded, it was no longer possible to set the background layer to the void layer.

Cause: the url parser validation checked for the 'void' string which is not in the background layers, and the setter only accepted null as a valid option.

Fix : we allowed the 'void' string value in both cases
@github-actions github-actions bot changed the title hotfix bgLayers #patch New Release v1.49.2 - #patch Dec 2, 2024
@cypress
Copy link

cypress bot commented Dec 2, 2024

web-mapviewer    Run #3947

Run Properties:  status check passed Passed #3947  •  git commit 92164e4ef5: Merge pull request #1151 from geoadmin/fix-PB-1259-change-bglayer-through-url
Project web-mapviewer
Branch Review develop
Run status status check passed Passed #3947
Run duration 01m 36s
Commit git commit 92164e4ef5: Merge pull request #1151 from geoadmin/fix-PB-1259-change-bglayer-through-url
Committer Pascal Barth
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 1
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 48
View all changes introduced in this branch ↗︎

@pakb pakb requested a review from ltkum December 2, 2024 11:19
Copy link
Contributor

@ltkum ltkum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@pakb pakb merged commit dad3e17 into master Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants