Merged
Conversation
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
feat-pb-995-cesium-wmts-composable
|
| Run status |
|
| Run duration | 05m 06s |
| Commit |
|
| Committer | Pascal Barth |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
21
|
Skipped
|
0
|
Passing
|
214
|
| View all changes introduced in this branch ↗︎ | |
sommerfe
approved these changes
Nov 29, 2024
src/modules/map/components/cesium/utils/useAddImageryLayer.composable.js
Outdated
Show resolved
Hide resolved
transform the Cesium WMTS component to composition API Adding a composable that can be used for WMS layers when we want to move them to composition API too. Issues fixed by this commit : - opacity when a layer as a specific config for 3D (like SWISSIMAGE) by giving the 3D config the same opacity as the 2D equivalent. The opacity of the 3D config was used, but the UI is editing the opacity of the 2D layer. - error that popped up in the console when switching from 3D to 2D, the camera position is set to null by the unmounted CesiumMap hook and then the sync camera plugin uses the camera value without checking its validity. Adding a little check to remove the error - External WMTS style wasn't properly applied to the 3D viewer, a good example is to load swissdatacube WMTS with layer diff_all_CH, as its default style isn't named "default" but something else
0fe8436 to
314cbca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
transform the Cesium WMTS component to composition API
Adding a composable that can be used for WMS layers when we want to move them to composition API too.
Issues fixed by this commit :
Test link