PB-1259: allow bgLayer modification through URL#1151
Merged
Conversation
Issue: when the application was already loaded, it was no longer possible to set the background layer to the void layer. Cause: the url parser validation checked for the 'void' string which is not in the background layers, and the setter only accepted null as a valid option. Fix : we allowed the 'void' string value in both cases
pakb
approved these changes
Dec 2, 2024
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
fix-PB-1259-change-bglayer-through-url
|
| Run status |
|
| Run duration | 04m 26s |
| Commit |
|
| Committer | Martin Künzi |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
21
|
Skipped
|
0
|
Passing
|
214
|
| View all changes introduced in this branch ↗︎ | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: when the application was already loaded, it was no longer possible to set the background layer to the void layer.
Cause: the url parser validation checked for the 'void' string which is not in the background layers, and the setter only accepted null as a valid option.
Fix : we allowed the 'void' string value in both cases
Test link