Conversation
added 2 commits
March 15, 2022 14:30
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
azeey
approved these changes
Mar 15, 2022
Author
|
Interesting new failure: https://build.osrfoundation.org/job/sdformat-ci-pr_any-homebrew-amd64/3232/testReport/junit/(root)/ElementMemoryLeak/SDFCreateDestroy/ I don't think I caused this one. It could just be that |
Member
I ran it again and it passed, so I guess it's flaky |
Member
|
https://github.com/Mergifyio backport sdf12 |
Contributor
✅ Backports have been createdDetails
|
mergify bot
pushed a commit
that referenced
this pull request
Jan 16, 2026
* Remove unnecessary copies * Clean up unused variables Signed-off-by: Michael Carroll <michael@openrobotics.org> (cherry picked from commit 297aef2) # Conflicts: # src/parser_urdf.cc # test/integration/joint_dom.cc # usd/src/cmd/sdf2usd.cc
scpeters
pushed a commit
that referenced
this pull request
Jan 16, 2026
* Remove unnecessary copies * Clean up unused variables Signed-off-by: Michael Carroll <michael@openrobotics.org> (cherry picked from commit 297aef2)
scpeters
pushed a commit
that referenced
this pull request
Jan 16, 2026
* Remove unnecessary copies * Clean up unused variables Signed-off-by: Michael Carroll <michael@openrobotics.org> (cherry picked from commit 297aef2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cleans up some unnecessary copies and unused variables.