Skip to content

Clean up compiler warnings (backport #882)#1619

Merged
scpeters merged 1 commit intosdf12from
mergify/bp/sdf12/pr-882
Jan 16, 2026
Merged

Clean up compiler warnings (backport #882)#1619
scpeters merged 1 commit intosdf12from
mergify/bp/sdf12/pr-882

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Jan 16, 2026

This cleans up some unnecessary copies and unused variables.

This is an automatic backport of pull request #882 done by Mergify.

@mergify mergify bot requested a review from azeey as a code owner January 16, 2026 19:48
@mergify mergify bot added the conflicts label Jan 16, 2026
@mergify mergify bot requested a review from scpeters as a code owner January 16, 2026 19:48
@mergify
Copy link
Copy Markdown
Contributor Author

mergify bot commented Jan 16, 2026

Cherry-pick of 297aef2 has failed:

On branch mergify/bp/sdf12/pr-882
Your branch is up to date with 'origin/sdf12'.

You are currently cherry-picking commit 297aef2c.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   src/Plugin.cc

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   src/parser_urdf.cc
	both modified:   test/integration/joint_dom.cc
	deleted by us:   usd/src/cmd/sdf2usd.cc

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts label Jan 16, 2026
@mergify mergify bot mentioned this pull request Jan 16, 2026
Merged
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Jan 16, 2026
@scpeters
Clean up compiler warnings (#882)
17dc81d 
* Remove unnecessary copies
* Clean up unused variables

Signed-off-by: Michael Carroll <michael@openrobotics.org>
(cherry picked from commit 297aef2)
@scpeters scpeters force-pushed the mergify/bp/sdf12/pr-882 branch from 897c11a to 17dc81d Compare January 16, 2026 19:59
@scpeters scpeters merged commit 4d1b5ea into sdf12 Jan 16, 2026
12 of 13 checks passed
@scpeters scpeters deleted the mergify/bp/sdf12/pr-882 branch January 16, 2026 21:35
@github-project-automation github-project-automation bot moved this from Inbox to Done in Core development Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@azeey azeey Awaiting requested review from azeey azeey is a code owner

@scpeters scpeters Awaiting requested review from scpeters scpeters is a code owner

Assignees

No one assigned

Labels

🏯 fortress Ignition Fortress

Projects

Core development
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@azeey @scpeters