Skip to content

Update Sensor DOM to Element functions and add tests#757

Merged
nkoenig merged 6 commits intosdf12from
sensor_to_element
Nov 23, 2021
Merged

Update Sensor DOM to Element functions and add tests#757
nkoenig merged 6 commits intosdf12from
sensor_to_element

Conversation

@iche033
Copy link
Copy Markdown
Contributor

@iche033 iche033 commented Nov 17, 2021 •
edited
Loading

🦟 Bug fix

Fixes #

Summary

Renamed PopulateElement() to ToElement() based on feedback from pull request #755

The PopulateElement functions were added in #753 and have not been released yet so this should not break API/ABI.

Added unit tests.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@iche033
update api
7056b82 
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@iche033
add more tests
e1a826b 
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@iche033
Merge branch 'sdf12' into sensor_to_element
6197025
@iche033
noise to elem test
7d630c0 
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@iche033 iche033 requested a review from nkoenig November 17, 2021 08:47
@github-actions github-actions bot added 🌱 garden Ignition Garden 🏯 fortress Ignition Fortress labels Nov 17, 2021
@iche033 iche033 requested a review from azeey November 17, 2021 08:48
@iche033
remove unused var
2ed0597 
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 17, 2021

Codecov Report

Merging #757 (e1a826b) into sdf12 (ad00668) will increase coverage by 0.04%.
The diff coverage is 90.00%.

❗ Current head e1a826b differs from pull request most recent head 2ed0597. Consider uploading reports for the commit 2ed0597 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##            sdf12     #757      +/-   ##
==========================================
+ Coverage   88.57%   88.62%   +0.04%     
==========================================
  Files          76       76              
  Lines       11740    11781      +41     
==========================================
+ Hits        10399    10441      +42     
+ Misses       1341     1340       -1
Impacted Files Coverage Δ
src/Lidar.cc 87.04% <66.66%> (-3.19%) ⬇️
src/Camera.cc 87.17% <84.21%> (+0.47%) ⬆️
src/Sensor.cc 92.01% <93.54%> (+1.45%) ⬆️
src/AirPressure.cc 100.00% <100.00%> (ø)
src/Altimeter.cc 100.00% <100.00%> (ø)
src/ForceTorque.cc 89.93% <100.00%> (+3.56%) ⬆️
src/Imu.cc 100.00% <100.00%> (ø)
src/Magnetometer.cc 100.00% <100.00%> (ø)
src/Noise.cc 95.83% <100.00%> (-0.04%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2a286c...2ed0597. Read the comment docs.

@iche033 iche033 mentioned this pull request Nov 18, 2021
Merged
8 tasks
@nkoenig
Copy link
Copy Markdown
Contributor

nkoenig commented Nov 22, 2021

@azeey , are you okay with this PR?

azeey
azeey approved these changes Nov 22, 2021
View reviewed changes
Copy link
Copy Markdown
Collaborator

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nkoenig nkoenig merged commit cc2d819 into sdf12 Nov 23, 2021
@nkoenig nkoenig deleted the sensor_to_element branch November 23, 2021 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@azeey azeey azeey approved these changes

@nkoenig nkoenig nkoenig approved these changes

Assignees

No one assigned

Labels

🏯 fortress Ignition Fortress 🌱 garden Ignition Garden

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@iche033 @codecov-commenter @nkoenig @azeey @j-rivero @osrf-triage