Add function to convert Sensor DOM to sdf::ElementPtr#753
Merged
Conversation
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
8 tasks
Codecov Report
@@ Coverage Diff @@
## sdf12 #753 +/- ##
==========================================
+ Coverage 88.41% 88.57% +0.15%
==========================================
Files 76 76
Lines 11457 11740 +283
==========================================
+ Hits 10130 10399 +269
- Misses 1327 1341 +14
Continue to review full report at Codecov.
|
* Suggestion to move dom conversion to sensor classes Signed-off-by: Nate Koenig <nate@openrobotics.org> * Remove file from smake Signed-off-by: Nate Koenig <nate@openrobotics.org> * remove header file in cmake Signed-off-by: Ian Chen <ichen@osrfoundation.org> * Fixing build Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Ian Chen <ichen@osrfoundation.org>
8 tasks
nkoenig
approved these changes
Nov 16, 2021
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 New feature
needed by gazebosim/gz-sim#1201
Summary
Adds a helper function to convert Sensor DOM to sdf::ElementPr.
This is needed when saving sensor properties to SDF file.
Note: Not all sensors are supported. I focused on implementing conversions for sensor types that are currently supported in Ignition gazebo
there are 2 sensor types in ignition that do not have SDF DOM classes so I didn't write conversions for them:
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge