Backport #721 to sdf9: Make exception for plugins when checking for name uniqueness#733
Merged
azeey merged 5 commits intogazebosim:sdf9from Oct 27, 2021
Merged
Conversation
added 4 commits
October 14, 2021 16:24
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
…im#721) Adds an exception for the <plugin> element so that no warning is emitted when a plugin name matches the names of other entities. Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## sdf9 #733 +/- ##
==========================================
- Coverage 86.88% 86.83% -0.05%
==========================================
Files 62 62
Lines 9734 9756 +22
==========================================
+ Hits 8457 8472 +15
- Misses 1277 1284 +7
Continue to review full report at Codecov.
|
chapulina
approved these changes
Oct 15, 2021
Collaborator
Author
|
@osrf-jenkins run tests please |
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-01-10/1228/1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
Summary
Backport #721 to sdf9.
Builds on #731
In addition, I've backported code for console redirection from
sdf11in 8e1d5e5Note to maintainers: Remember to use Squash-Merge