Make exception for plugins when checking for name uniqueness#721
Merged
azeey merged 3 commits intogazebosim:mainfrom Sep 30, 2021
Merged
Make exception for plugins when checking for name uniqueness#721azeey merged 3 commits intogazebosim:mainfrom
azeey merged 3 commits intogazebosim:mainfrom
Conversation
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## main #721 +/- ##
==========================================
+ Coverage 88.20% 88.21% +0.01%
==========================================
Files 76 76
Lines 11417 11430 +13
==========================================
+ Hits 10070 10083 +13
Misses 1347 1347
Continue to review full report at Codecov.
|
scpeters
reviewed
Sep 29, 2021
Member
scpeters
left a comment
There was a problem hiding this comment.
just one minor nit about wording of documentation
looks good otherwise
|
|
||
| /// \brief List of elements to which exceptions are made when checking for | ||
| /// name uniqueness. | ||
| /// \return List of element types that are allowed to name collisions. |
Member
There was a problem hiding this comment.
missing a verb? "allowed to have name collisions"?
added 2 commits
September 29, 2021 19:54
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
scpeters
approved these changes
Sep 30, 2021
azeey
pushed a commit
to azeey/sdformat
that referenced
this pull request
Oct 15, 2021
…im#721) Adds an exception for the <plugin> element so that no warning is emitted when a plugin name matches the names of other entities. Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #712
Fixes #294
Summary
As discussed in #712, #294 and possibly other issues, the
nameattribute of<plugin>is used by downstream applications like ign-gazebo to specify the class name within the plugin, so name collisions can occur frequently. This PR adds an exception for the<plugin>so that no warning is emitted when a plugin name matches the names of other entities.I've added overloads to functions in
sdf::Elementso that this PR can be backported tosdf9.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge