Retry fix for unsafe initialization in graph classes#1460
Merged
Conversation
Follow-up to gz-math#606. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
8 tasks
Member
Author
|
I've merged gazebosim/gz-math#612 and rebuilt nightly debs, and CI is almost finished and all completed jobs have passed |
Member
Author
|
this will fix the clang warnings on main: |
caguero
approved these changes
Aug 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Follow-up to gazebosim/gz-math#612.
Summary
The is a second attempt at following up on the fix for potentially unsafe initialization issues in the
graph::Edgeandgraph::Vertexclasses after the first attempts in gazebosim/gz-math#606 and #1458 were reverted in gazebosim/gz-math#609 and #1459 due to test failures induced in gz-sim (documented in osrf/buildfarm-tools#67 (comment)). This pull request should be merged after gazebosim/gz-math#612, which uses a static local variable instead of dynamic memory allocation and doesn't cause gz-sim test failures in my testing.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.