Retry fix for unsafe initialization in graph classes#612
Merged
Conversation
* Avoid constructor/destructor fiascos in graph class * Deprecations and migration guide. Signed-off-by: Carlos Agüero <caguero@openrobotics.org> Signed-off-by: Carlos Agüero <cen.aguero@gmail.com> Co-authored-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
8 tasks
Member
Author
|
using the |
8 tasks
ahcorde
approved these changes
Jul 19, 2024
azeey
requested changes
Jul 19, 2024
include/gz/math/graph/Edge.hh
Outdated
| template<typename E, typename EdgeType> | ||
| EdgeType &NullEdge() | ||
| { | ||
| static EdgeType e( |
Contributor
There was a problem hiding this comment.
This is still problematic depending the given types E, and EdgeType because the destructor eventually runs when the program exits. According to the Google style guide, it's best to allocate memory from the heap and never delete it, which will avoid calling the destructor. gz::utils::NeverDestroyed does exactly that, so I recommend we switch to that.
Member
Author
There was a problem hiding this comment.
rerunning gz-sim CI https://build.osrfoundation.org/job/gz_sim-ci-pr_any-homebrew-amd64/693/
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
azeey
approved these changes
Jul 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #269.
Summary
The is a second attempt at fixing the potentially unsafe initialization issues in the
graph::Edgeandgraph::Vertexclasses after the first attempt in #606 was reverted in #609 due to test failures that it caused in gz-sim (documented in osrf/buildfarm-tools#67 (comment)). This pull request uses a static local variable instead of dynamic memory allocation and doesn't cause gz-sim test failures in my testing.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.