Revert "FrameSemantics: fix NullVertex warnings (#1458)"#1459
Merged
Conversation
This reverts commit e40331e. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
8 tasks
caguero
approved these changes
Jul 17, 2024
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
This reverts commit e40331e.
Summary
It appears that #606 and #1458 caused test failures in gz-sim (see osrf/buildfarm-tools#67 (comment)). I opened a test PR in gz-sim (gazebosim/gz-sim#2482) that builds against gz-math8 and sdformat15 with those changes reverted, and the tests were fixed:
I don't know why this broke tests, but I propose reverting these changes for now until we can figure it out.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Rebase-and-Merge.