Skip to content

Bazel: small fixes for ionic#683

Merged
scpeters merged 2 commits intogz-math8from
scpeters/bazel_ionic_fixes
Jun 18, 2025
Merged

Bazel: small fixes for ionic#683
scpeters merged 2 commits intogz-math8from
scpeters/bazel_ionic_fixes

Conversation

@scpeters
Copy link
Copy Markdown
Member

🦟 Bug fix

Manual forward port of some bazel fixes

Summary

I recently attempted to merge forward from gz-math7 to gz-math8, and there are lots of conflicts in the bazel BUILD files. I noticed while looking through the conflicts that there were two things missing on the gz-math8 branch:

  • 37789a1: the auto-generated eigen3.hh header file
  • 139dc28: support for the src/graph unit tests

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Generated-by: Remove this if GenAI was not used.

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.

scpeters added 2 commits June 17, 2025 23:50
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Jun 18, 2025
@scpeters scpeters changed the title Scpeters/bazel ionic fixes Bazel: small fixes for ionic Jun 18, 2025
@scpeters scpeters marked this pull request as ready for review June 18, 2025 16:37
Copy link
Copy Markdown
Contributor

@shameekganguly shameekganguly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Steve!

@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Jun 18, 2025
@scpeters scpeters merged commit 59edea2 into gz-math8 Jun 18, 2025
15 checks passed
@scpeters scpeters deleted the scpeters/bazel_ionic_fixes branch June 18, 2025 16:57
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Jun 18, 2025
bazel-io pushed a commit to bazelbuild/bazel-central-registry that referenced this pull request Jun 18, 2025
Add a new patch to BUILD.bazel file to generate an include header,
`math.hh`, that is needed by downstream packages

Changes in 8.1.1.bcr.1
* added `generate_*_include_header.patch` that contains changes from
gazebosim/gz-math#681 and
gazebosim/gz-math#683
* updated `rules_gazebo` to version `0.0.6`

---------

Signed-off-by: Ian Chen <ichen@openrobotics.org>
filmil pushed a commit to filmil/bazel-central-registry that referenced this pull request Jun 23, 2025
Add a new patch to BUILD.bazel file to generate an include header,
`math.hh`, that is needed by downstream packages

Changes in 8.1.1.bcr.1
* added `generate_*_include_header.patch` that contains changes from
gazebosim/gz-math#681 and
gazebosim/gz-math#683
* updated `rules_gazebo` to version `0.0.6`

---------

Signed-off-by: Ian Chen <ichen@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏛️ ionic Gazebo Ionic

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants