Merged
Conversation
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Member
|
Hello @mjcarroll, modules you maintain (gz-math) have been updated in this PR. |
Contributor
Author
|
@bazel-io skip_check unstable_url |
Signed-off-by: Ian Chen <ichen@openrobotics.org>
mjcarroll
approved these changes
Jun 18, 2025
bazel-io
approved these changes
Jun 18, 2025
Member
bazel-io
left a comment
There was a problem hiding this comment.
Hello @bazelbuild/bcr-maintainers, all modules in this PR have been approved by their maintainers. This PR will be merged if all presubmit checks pass.
9 tasks
filmil
pushed a commit
to filmil/bazel-central-registry
that referenced
this pull request
Jun 23, 2025
Add a new patch to BUILD.bazel file to generate an include header, `math.hh`, that is needed by downstream packages Changes in 8.1.1.bcr.1 * added `generate_*_include_header.patch` that contains changes from gazebosim/gz-math#681 and gazebosim/gz-math#683 * updated `rules_gazebo` to version `0.0.6` --------- Signed-off-by: Ian Chen <ichen@openrobotics.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new patch to BUILD.bazel file to generate an include header,
math.hh, that is needed by downstream packagesChanges in 8.1.1.bcr.1
generate_*_include_header.patchthat contains changes from [Bazel] Generate math.hh header file gazebosim/gz-math#681 and Bazel: small fixes for ionic gazebosim/gz-math#683rules_gazeboto version0.0.6