Skip to content

Adds bounds retrieval for TimeVarying grid class.#508

Merged
arjo129 merged 7 commits intogz-math7from
arjo/feat/bounds
Oct 11, 2022
Merged

Adds bounds retrieval for TimeVarying grid class.#508
arjo129 merged 7 commits intogz-math7from
arjo/feat/bounds

Conversation

@arjo129
Copy link
Copy Markdown
Contributor

@arjo129 arjo129 commented Sep 22, 2022

This is required for visualization purposes.

Signed-off-by: Arjo Chakravarty arjo@openrobotics.org

This is required for visualization purposes.

Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Sep 22, 2022
Copy link
Copy Markdown
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linters

Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
@azeey azeey requested review from ahcorde and caguero October 3, 2022 18:28
ahcorde
ahcorde previously requested changes Oct 4, 2022
Copy link
Copy Markdown
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linters still failing

arjo129 added a commit to gazebosim/gz-sim that referenced this pull request Oct 5, 2022
Depends on:
* gazebosim/gz-math#508
* gazebosim/gz-common#446
Work in progress.

Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 7, 2022

Codecov Report

Merging #508 (4a8772e) into gz-math7 (39e48c1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##           gz-math7     #508   +/-   ##
=========================================
  Coverage     99.70%   99.70%           
=========================================
  Files            77       77           
  Lines          7007     7026   +19     
=========================================
+ Hits           6986     7005   +19     
  Misses           21       21           
Impacted Files Coverage Δ
include/gz/math/TimeVaryingVolumetricGrid.hh 100.00% <100.00%> (ø)
...de/gz/math/TimeVaryingVolumetricGridLookupField.hh 100.00% <100.00%> (ø)
include/gz/math/VolumetricGridLookupField.hh 96.51% <100.00%> (+0.12%) ⬆️
include/gz/math/detail/AxisIndex.hh 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

scpeters and others added 4 commits October 7, 2022 16:34
Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
@arjo129 arjo129 requested a review from ahcorde October 10, 2022 01:45
@arjo129 arjo129 mentioned this pull request Oct 10, 2022
38 tasks
Copy link
Copy Markdown
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arjo129 arjo129 dismissed ahcorde’s stale review October 11, 2022 12:30

Changes addressed

@arjo129 arjo129 merged commit 1bcf7d1 into gz-math7 Oct 11, 2022
@arjo129 arjo129 deleted the arjo/feat/bounds branch October 11, 2022 12:30
arjo129 added a commit to gazebosim/gz-sim that referenced this pull request Nov 1, 2022
Depends on:
* gazebosim/gz-math#508
* gazebosim/gz-common#446
Work in progress.

Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🌱 garden Ignition Garden

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants