Skip to content

packages.apt: install libpython3-dev#414

Merged
scpeters merged 1 commit intogazebosim:mainfrom
scpeters:install_python_dev
Apr 29, 2022
Merged

packages.apt: install libpython3-dev#414
scpeters merged 1 commit intogazebosim:mainfrom
scpeters:install_python_dev

Conversation

@scpeters
Copy link
Copy Markdown
Member

🦟 Bug fix

Fixes Ubuntu 20.04 builds on main that fail to find Python

Summary

The Ubuntu 20.04 builds on main fail to find Python since gazebo-tooling/release-tools#709 was merged and the libpython3-dev was no longer installed in our Jenkins Ubuntu builds. This adds the package to our packages.apt file.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Apr 29, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 29, 2022

Codecov Report

Merging #414 (66c5ef6) into main (fb741dd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #414   +/-   ##
=======================================
  Coverage   99.90%   99.90%           
=======================================
  Files          46       46           
  Lines        4260     4260           
=======================================
  Hits         4256     4256           
  Misses          4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb741dd...66c5ef6. Read the comment docs.

@scpeters scpeters requested a review from methylDragon April 29, 2022 22:26
Copy link
Copy Markdown
Contributor

@methylDragon methylDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this was why it was failing during the bumps :o
CI is green, so we should be ok.

Pinging @chapulina to double check.

@scpeters scpeters merged commit a8a5b94 into gazebosim:main Apr 29, 2022
@scpeters scpeters deleted the install_python_dev branch April 29, 2022 23:13
scpeters added a commit to scpeters/gz-math that referenced this pull request Apr 29, 2022
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters added a commit that referenced this pull request May 2, 2022
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🌱 garden Ignition Garden

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants