Completely rely on packages.apt from Garden#709
Merged
Conversation
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Contributor
Author
|
YOLO merging to unblock #685 🙏🏽 🤞🏽 |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building on top of @methylDragon 's work in:
This PR completely skips all dependency resolution for Garden versions. We should probably be able to change this all the way back to Citadel, but for now sticking to Garden to be quicker.
Builds have been installing more than they needed for a while, but it hasn't been a problem until now because all libraries could be installed side-by-side. But while we work on #698,
ign-tools2will be conflicting withign-tools1for a while. So it's especially important that we only install what we need, as described onpackages.apt.➡️ I recommend hiding whitespace changes for easier review