Skip to content

Fix Focal on Jenkins#364

Merged
chapulina merged 2 commits intoign-math6from
chapulina/6/focal_dep
Jan 7, 2022
Merged

Fix Focal on Jenkins#364
chapulina merged 2 commits intoign-math6from
chapulina/6/focal_dep

Conversation

@chapulina
Copy link
Copy Markdown
Contributor

@chapulina chapulina commented Jan 7, 2022

🦟 Bug fix

Summary

ign-math builds have been failing on Jenkins since we migrated to Focal in gazebo-tooling/release-tools#565

As @j-rivero found out, adding the python3-distutils dependency fixes the build.

I haven't looked into why this extra dependency is needed by Jenkins but not by GitHub actions, which has been successfully building Python bindings without this dependency on Focal.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@chapulina
Fix Focal on Jenkins
075b962 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina requested review from j-rivero and scpeters January 7, 2022 17:25
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel labels Jan 7, 2022
@chapulina chapulina mentioned this pull request Jan 7, 2022
Merged
7 tasks
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 7, 2022 •
edited
Loading

Codecov Report

Merging #364 (7afd1d3) into ign-math6 (1c4a9f7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           ign-math6     #364   +/-   ##
==========================================
  Coverage      99.65%   99.65%           
==========================================
  Files             67       67           
  Lines           6380     6380           
==========================================
  Hits            6358     6358           
  Misses            22       22

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c4a9f7...7afd1d3. Read the comment docs.

@mjcarroll
Copy link
Copy Markdown

mjcarroll commented Jan 7, 2022

I haven't looked into why this extra dependency is needed by Jenkins but not by GitHub actions, which has been successfully building Python bindings without this dependency on Focal.

We are installing it, because python3-pip depends on python3-distutils https://github.com/ignition-tooling/action-ignition-ci/blob/master/entrypoint.sh#L25

@chapulina
Copy link
Copy Markdown
Contributor Author

chapulina commented Jan 7, 2022

We are installing it, because python3-pip depends on python3-distutils

Ahhh sneaky! Thanks for that, glad that Jenkins caught the missing dependency!

@chapulina
Add project() too
7afd1d3 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina enabled auto-merge (squash) January 7, 2022 20:56
@chapulina chapulina merged commit 4b25160 into ign-math6 Jan 7, 2022
@chapulina chapulina deleted the chapulina/6/focal_dep branch January 7, 2022 21:21
mjcarroll pushed a commit that referenced this pull request Jan 7, 2022
@chapulina
Fix Focal on Jenkins (#364)
7ad6777 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
mjcarroll pushed a commit that referenced this pull request Jan 7, 2022
@chapulina
Fix Focal on Jenkins (#364)
6a80aa4 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@osrf-triage
Copy link
Copy Markdown

osrf-triage commented Mar 1, 2022

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

@ahcorde ahcorde ahcorde approved these changes

@j-rivero j-rivero Awaiting requested review from j-rivero

@scpeters scpeters Awaiting requested review from scpeters scpeters is a code owner

Assignees

No one assigned

Labels

🏰 citadel Ignition Citadel 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress Gazebo 1️1️ Dependency of Gazebo classic version 11

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@chapulina @mjcarroll @osrf-triage @ahcorde @j-rivero