Skip to content

Refactor finding pybind11#360

Merged
chapulina merged 13 commits intoign-math6from
chapulina/6/pybind11_cmake
Jan 11, 2022
Merged

Refactor finding pybind11#360
chapulina merged 13 commits intoign-math6from
chapulina/6/pybind11_cmake

Conversation

@chapulina
Copy link
Copy Markdown
Contributor

@chapulina chapulina commented Jan 4, 2022 •
edited
Loading

Summary

  • Move find_package call to top-level CMakeLists together with other dependencies
  • Print status messages if found / not found for debugging

The change in src/python_pybind11/CMakeLists.txt is mainly whitespace.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@chapulina
Refactor finding pybind11
a53d7e3 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina requested a review from ahcorde January 4, 2022 23:22
@chapulina chapulina requested a review from scpeters as a code owner January 4, 2022 23:22
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel labels Jan 4, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 4, 2022 •
edited
Loading

Codecov Report

Merging #360 (42be2fa) into chapulina/6/focal_dep (075b962) will not change coverage.
The diff coverage is n/a.

❗ Current head 42be2fa differs from pull request most recent head d4bafe6. Consider uploading reports for the commit d4bafe6 to get more accurate results
Impacted file tree graph

@@                  Coverage Diff                   @@
##           chapulina/6/focal_dep     #360   +/-   ##
======================================================
  Coverage                  99.65%   99.65%           
======================================================
  Files                         67       67           
  Lines                       6380     6380           
======================================================
  Hits                        6358     6358           
  Misses                        22       22

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 075b962...d4bafe6. Read the comment docs.

@chapulina
Set python version before find_package
2f92f85 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
version
589008f 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina mentioned this pull request Jan 5, 2022
Merged
@chapulina
Swap order
90d7302 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
scpeters
scpeters reviewed Jan 5, 2022
View reviewed changes
@chapulina
Use IgnPython
ca39f94 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
Fix cmake variable
37fa286 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
don't check pythoninterp
4bb982f 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@scpeters scpeters mentioned this pull request Jan 5, 2022
Merged
@scpeters
Use include(IgnPython)
20104ae 
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@j-rivero
Copy link
Copy Markdown
Contributor

j-rivero commented Jan 5, 2022

I think we have a missing dep in Jenkins, I'm looking into it.

@j-rivero j-rivero mentioned this pull request Jan 5, 2022
Closed
@chapulina
Copy link
Copy Markdown
Contributor Author

chapulina commented Jan 5, 2022

The ign-math6 branch is failing too since we moved to Focal on Jenkins:

https://build.osrfoundation.org/job/ignition_math-ci-ign-math6-focal-amd64/1/console

@chapulina
Add python3-distutils
4fbb1b6 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
Fix warning
507f96e 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
Copy link
Copy Markdown
Contributor Author

chapulina commented Jan 5, 2022

The ign-math6 branch is failing too since we moved to Focal on Jenkins:

This PR should fix it

@chapulina chapulina changed the title Refactor finding pybind11 Refactor finding pybind11 and fix Focal on Jenkins Jan 5, 2022
@chapulina chapulina mentioned this pull request Jan 7, 2022
Merged
7 tasks
@chapulina
Copy link
Copy Markdown
Contributor Author

chapulina commented Jan 7, 2022

I broke off the Focal fix into #364 for easier review.

@chapulina chapulina changed the title Refactor finding pybind11 and fix Focal on Jenkins Refactor finding pybind11 Jan 7, 2022
@chapulina
Merge branch 'chapulina/6/focal_dep' into chapulina/6/pybind11_cmake
d4bafe6 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina changed the base branch from ign-math6 to chapulina/6/focal_dep January 7, 2022 17:27
Base automatically changed from chapulina/6/focal_dep to ign-math6 January 7, 2022 21:21
@chapulina chapulina requested a review from scpeters January 10, 2022 19:45
@chapulina chapulina merged commit fa67ea8 into ign-math6 Jan 11, 2022
@chapulina chapulina deleted the chapulina/6/pybind11_cmake branch January 11, 2022 18:29
@osrf-triage
Copy link
Copy Markdown

osrf-triage commented Mar 1, 2022

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahcorde ahcorde ahcorde approved these changes

@scpeters scpeters Awaiting requested review from scpeters scpeters is a code owner

Assignees

No one assigned

Labels

🏰 citadel Ignition Citadel 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress Gazebo 1️1️ Dependency of Gazebo classic version 11

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@chapulina @j-rivero @osrf-triage @ahcorde @scpeters