Conversation
|
@jmchilton the failing test is because BWA returns error code of 1 while printing the help. How do you want me to solve this? Hacking in cheetah, like |
|
Yeah - I'd revert the changes for those few tools. It is fine to use stdio if an exit code of 1 doesn't indicate an error - at least in this context we expect that to be the exit code so the stdio if fine. The rest of this is super awesome though - thanks for going through and doing all of that! One problem is that the line numbers of highlighting things in the RST need to be updated when you change the seqtk example tools and tool_init output. We can merge as is and then create an issue for that if you'd like and assign me - I need to rewalk through all the tutorials with a new copy of planemo machine anyway before the GCC - I can fix those as I go. |
Other small formatting tweaks - but less than galaxyproject#674 since I'm trying to keep these tools the way they are when tool_init generates them - at least for those options. This also doesn't strip stdio from other places like the bwa test tool that broke the tests in galaxyproject#674.
|
I'm going to cherry-pick e0803b7 and add it to my next docs update. Otherwise I redid the tool builder and seqtk changes in #693 - but without the quotes changes since tool_init doesn't do it that way (we should fix tool_init to though down the road) and I also changed the macro version of tool_init to not add a stdio block. Hope this okay. |
xref: #644 and #502