Skip to content

small steps to remove stdio from the docs in favor of detect_errors#674

Closed
bgruening wants to merge 5 commits intomasterfrom
docs
Closed

small steps to remove stdio from the docs in favor of detect_errors#674
bgruening wants to merge 5 commits intomasterfrom
docs

Conversation

@bgruening
Copy link
Member

@bgruening bgruening commented May 20, 2017

xref: #644 and #502

@bgruening
Copy link
Member Author

@jmchilton the failing test is because BWA returns error code of 1 while printing the help. How do you want me to solve this? Hacking in cheetah, like | grep "bwa" or reverting to stdio for these few tools?

@jmchilton
Copy link
Member

Yeah - I'd revert the changes for those few tools. It is fine to use stdio if an exit code of 1 doesn't indicate an error - at least in this context we expect that to be the exit code so the stdio if fine. The rest of this is super awesome though - thanks for going through and doing all of that!

One problem is that the line numbers of highlighting things in the RST need to be updated when you change the seqtk example tools and tool_init output. We can merge as is and then create an issue for that if you'd like and assign me - I need to rewalk through all the tutorials with a new copy of planemo machine anyway before the GCC - I can fix those as I go.

jmchilton added a commit to jmchilton/planemo that referenced this pull request Jun 18, 2017
Other small formatting tweaks - but less than galaxyproject#674 since I'm trying to keep these tools the way they are when tool_init generates them - at least for those options. This also doesn't strip stdio from other places like the bwa test tool that broke the tests in galaxyproject#674.
@jmchilton
Copy link
Member

I'm going to cherry-pick e0803b7 and add it to my next docs update. Otherwise I redid the tool builder and seqtk changes in #693 - but without the quotes changes since tool_init doesn't do it that way (we should fix tool_init to though down the road) and I also changed the macro version of tool_init to not add a stdio block.

Hope this okay.

@jmchilton jmchilton closed this Jun 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants