Skip to content

Lint exit code#292

Merged
jmchilton merged 2 commits intogalaxyproject:masterfrom
jmchilton:lint_exit_code
Sep 10, 2015
Merged

Lint exit code#292
jmchilton merged 2 commits intogalaxyproject:masterfrom
jmchilton:lint_exit_code

Conversation

@jmchilton
Copy link
Member

Ping @mvdbeek. xref #281.

marius and others added 2 commits August 13, 2015 15:23
This is work started by @mvdbeek with PR galaxyproject#281.

Refinements include:

 - Using an abstract object instead of simple string for indicating tool failure.
 - Extending shed_lint --tools with the failing behavior.
 - Not having other, non-lint uses the tool directory loading register tool errors.*
 - Adds test cases for both shed_lint and lint.

* It may in fact be the case that these should handle this error, but they weren't really checking for the string "error" so I was worried these would just fail with obtuse error messages. This should be revisited down the road I thin.
@mvdbeek
Copy link
Member

mvdbeek commented Sep 10, 2015

Very nice, thanks @jmchilton.
This is a lesson about test-driven dev for me!

jmchilton added a commit that referenced this pull request Sep 10, 2015
@jmchilton jmchilton merged commit d33987e into galaxyproject:master Sep 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants