Return non-zero exitcode if planemo fails to load a xml file due to m…#281
Closed
mvdbeek wants to merge 1 commit intogalaxyproject:masterfrom
Closed
Return non-zero exitcode if planemo fails to load a xml file due to m…#281mvdbeek wants to merge 1 commit intogalaxyproject:masterfrom
mvdbeek wants to merge 1 commit intogalaxyproject:masterfrom
Conversation
…alformed xml tags.
jmchilton
added a commit
to jmchilton/planemo
that referenced
this pull request
Sep 10, 2015
This is work started by @mvdbeek with PR galaxyproject#281. Refinements include: - Using an abstract object instead of simple string for indicating tool failure. - Extending shed_lint --tools with the failing behavior. - Not having other, non-lint uses the tool directory loading register tool errors.* - Adds test cases for both shed_lint and lint. * It may in fact be the case that these should handle this error, but they weren't really checking for the string "error" so I was worried these would just fail with obtuse error messages. This should be revisited down the road I thin.
Merged
Member
|
It is an absolute embarrassment I took so long to get to this @mvdbeek - I am really sorry. Thanks for the fix, I have made some modifications - do you want to take a look at #292 and see if it is okay. The refinements are described in jmchilton@84c70b3. |
Member
Author
|
Thanks @jmchilton , it looks very good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…alformed xml tags.
See #280