Sort planemo shed_upload tar-ball by filename#164
Merged
jmchilton merged 1 commit intogalaxyproject:masterfrom Apr 30, 2015
Merged
Sort planemo shed_upload tar-ball by filename#164jmchilton merged 1 commit intogalaxyproject:masterfrom
jmchilton merged 1 commit intogalaxyproject:masterfrom
Conversation
See GitHub issue galaxyproject#159. Note this does not explicitly handle directories, thus any empty directory would be missing from the tar-ball.
Member
|
Awesome - thanks a bunch! |
jmchilton
added a commit
that referenced
this pull request
Apr 30, 2015
Sort planemo shed_upload tar-ball by filename
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would resolve issue #159 by the simple expedient of building a list of all the files in the staging directory, and using the sorted list to build the tar-ball.
Note this does not explicitly handle directories, thus any empty directory would be missing from the tar-ball. Since the Tool Shed uses hg internally this does not matter (same for git too).
e.g. silly test case showing the desired sorting: