Skip to content

Sort planemo shed_upload tar-ball by filename#164

Merged
jmchilton merged 1 commit intogalaxyproject:masterfrom
peterjc:sort_tar_ball
Apr 30, 2015
Merged

Sort planemo shed_upload tar-ball by filename#164
jmchilton merged 1 commit intogalaxyproject:masterfrom
peterjc:sort_tar_ball

Conversation

@peterjc
Copy link
Contributor

@peterjc peterjc commented Apr 30, 2015

This would resolve issue #159 by the simple expedient of building a list of all the files in the staging directory, and using the sorted list to build the tar-ball.

Note this does not explicitly handle directories, thus any empty directory would be missing from the tar-ball. Since the Tool Shed uses hg internally this does not matter (same for git too).

e.g. silly test case showing the desired sorting:

$ planemo shed_upload --tar_only  ~/repositories/pico_galaxy/tools/venn_list && tar -tzf shed_upload.tar.gz
cp /tmp/tmpYAjHCW shed_upload.tar.gz
aaa
test-data/magic.pdf
test-data/rhodopsin_proteins.fasta
test-data/venn_list.tabular
test-dataAAA
tools/venn_list/README.rst
tools/venn_list/tool_dependencies.xml
tools/venn_list/venn_list.py
tools/venn_list/venn_list.xml
toolsAAA
zzz

See GitHub issue galaxyproject#159.

Note this does not explicitly handle directories, thus any empty
directory would be missing from the tar-ball.
@jmchilton
Copy link
Member

Awesome - thanks a bunch!

jmchilton added a commit that referenced this pull request Apr 30, 2015
Sort planemo shed_upload tar-ball by filename
@jmchilton jmchilton merged commit 3b45e59 into galaxyproject:master Apr 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants