Skip to content

Add switch to prevent early termination of workflow runs#1518

Merged
mvdbeek merged 7 commits intogalaxyproject:masterfrom
kostrykin:dev/no_early_termination
May 5, 2025
Merged

Add switch to prevent early termination of workflow runs#1518
mvdbeek merged 7 commits intogalaxyproject:masterfrom
kostrykin:dev/no_early_termination

Conversation

@kostrykin
Copy link
Contributor

Add the --no_early_termination switch to prevent early termination of workflow runs.

I needed such behavior, so I implemented the switch. I'm not really familiar with the internals of planemo, so maybe it's not the best implementation, but it would be nice to work this towards getting it merged.

@kostrykin
Copy link
Contributor Author

It mostly works. There are just 3 jobs in my workflow that run significantly longer than the others (2181 jobs) and Planemo waits patiently until all but these 3 jobs are finished, and creates the correct XUnit file. However, these 3 jobs are still reported as running in the XUnit file.

Co-authored-by: Marius van den Beek <m.vandenbeek@gmail.com>
@mvdbeek
Copy link
Member

mvdbeek commented Apr 30, 2025

@kostrykin
Copy link
Contributor Author

https://github.com/galaxyproject/planemo/actions/runs/14729205708/job/41346995815?pr=1518 that looks relevant

Thanks @mvdbeek I think I fixed it in 06f7138, can you please approve the workflow to re-run the tests?

@mvdbeek mvdbeek force-pushed the dev/no_early_termination branch from 06f7138 to a29ce52 Compare April 30, 2025 11:07
@kostrykin
Copy link
Contributor Author

@mvdbeek Can you please approve the workflow run again?

@mvdbeek mvdbeek merged commit 2e023b8 into galaxyproject:master May 5, 2025
13 of 14 checks passed
@mvdbeek
Copy link
Member

mvdbeek commented May 5, 2025

Thank you @kostrykin!

@mvdbeek
Copy link
Member

mvdbeek commented May 22, 2025

@kostrykin do you think you could provide a small test workflow that exercises the behavior ? I think #1510 is also doing this in a conflicting way, and does in fact effectively make --no_early_termination the default (and only) behavior.

mvdbeek added a commit to jmchilton/planemo that referenced this pull request May 22, 2025
`--no-early-termination` is the current behavior. `--fail-fast` could be
an option to implement.
@kostrykin
Copy link
Contributor Author

kostrykin commented May 22, 2025

@mvdbeek You mean the behavior that I described here?

I think this workflow should reproduce this: https://usegalaxy.eu/u/kostrykin/w/test-input-images-small-1

Steps to reproduce:

  1. Clone the repo https://github.com/FAIR-imaging/galaxy-tool-test-workflow
  2. Save https://usegalaxy.eu/u/kostrykin/w/test-input-images-small-1 as test_tools.ga (overwrite) or use the workflow that comes with the repo (takes longer to run).
  3. Run python create_test_data.py
  4. Set GALAXY_API_KEY and run
planemo run test_tools.ga test_tools-job.yml \
  --engine external_galaxy \
  --galaxy_url https://usegalaxy.eu \
  --galaxy_user_key $GALAXY_API_KEY \
  --test_output_xunit tests.xunit \
  --simultaneous_uploads \
  --no_early_termination

@mvdbeek
Copy link
Member

mvdbeek commented May 22, 2025

Yes, thank you!

mvdbeek added a commit to mvdbeek/planemo that referenced this pull request Jun 16, 2025
`--no-early-termination` is the current behavior. `--fail-fast` could be
an option to implement.
mvdbeek added a commit to jmchilton/planemo that referenced this pull request Jun 18, 2025
`--no-early-termination` is the current behavior. `--fail-fast` could be
an option to implement.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants