Add switch to prevent early termination of workflow runs#1518
Add switch to prevent early termination of workflow runs#1518mvdbeek merged 7 commits intogalaxyproject:masterfrom
Conversation
|
It mostly works. There are just 3 jobs in my workflow that run significantly longer than the others (2181 jobs) and Planemo waits patiently until all but these 3 jobs are finished, and creates the correct XUnit file. However, these 3 jobs are still reported as |
Co-authored-by: Marius van den Beek <m.vandenbeek@gmail.com>
Thanks @mvdbeek I think I fixed it in 06f7138, can you please approve the workflow to re-run the tests? |
06f7138 to
a29ce52
Compare
|
@mvdbeek Can you please approve the workflow run again? |
|
Thank you @kostrykin! |
|
@kostrykin do you think you could provide a small test workflow that exercises the behavior ? I think #1510 is also doing this in a conflicting way, and does in fact effectively make |
`--no-early-termination` is the current behavior. `--fail-fast` could be an option to implement.
|
@mvdbeek You mean the behavior that I described here? I think this workflow should reproduce this: https://usegalaxy.eu/u/kostrykin/w/test-input-images-small-1 Steps to reproduce:
planemo run test_tools.ga test_tools-job.yml \
--engine external_galaxy \
--galaxy_url https://usegalaxy.eu \
--galaxy_user_key $GALAXY_API_KEY \
--test_output_xunit tests.xunit \
--simultaneous_uploads \
--no_early_termination |
|
Yes, thank you! |
`--no-early-termination` is the current behavior. `--fail-fast` could be an option to implement.
`--no-early-termination` is the current behavior. `--fail-fast` could be an option to implement.
Add the
--no_early_terminationswitch to prevent early termination of workflow runs.I needed such behavior, so I implemented the switch. I'm not really familiar with the internals of planemo, so maybe it's not the best implementation, but it would be nice to work this towards getting it merged.