Replace Galaxy interactor galaxy_requests_post with make_post_request from BioBlend#1201
Conversation
mvdbeek
left a comment
There was a problem hiding this comment.
That seems like a good idea. mvdbeek/galaxy@b7ab45d#diff-06835be1d1943ebce8373e2cd1f8e86c7b7813b720398850c978b734dd29e2da is where galaxy_requests_post was dropped.
|
Wow, sorry I didn't find any other reference in the codebase and didn't consider this method may be used in external projects. Thanks for fixing it @simonbray! |
90f1903 to
7d30dc7
Compare
|
@davelopez no worries, I think it isn't realistic to check all dependent projects every time you refactor some code. |
|
We should IMO pin requirements for releases of planemo. That is a common technique when you release applications (as opposed to libraries, where you should not pin). I think planemo's use as a library is not that common, so I don't think there are many downsides. |
|
thanks for fixing this @simonbray ! @davelopez when dropping an exposed method you can do sanity check by entering something like this in a github search: edit: that said, the method had this as docs 🤣
|
since planemo test is broken galaxyproject/planemo#1201
|
Thanks everyone, I'll cut a new release in the 0.74 version range. If/when we merge #1203 we should probably jump to 0.75 |
|
New release is on PyPI: https://pypi.org/project/planemo/0.74.9/ |
Planemo tests are currently failing here (bgruening/galaxytools#1173) with
It seems to be because the
galaxy_requests_postmethod was removed in Galaxy. Hopefully replacing it with BioBlend'smake_post_requestmethod will fix it.