Add poetry setup to produce locked releases#1203
Add poetry setup to produce locked releases#1203mvdbeek wants to merge 13 commits intogalaxyproject:masterfrom
Conversation
Co-authored-by: Nicola Soranzo <nicola.soranzo@gmail.com>
Co-authored-by: Nicola Soranzo <nicola.soranzo@gmail.com>
|
Yay, all green. What do you think about this @jmchilton ? |
Dep resolution on my laptop is a bit better, update.
pyproject.toml
Outdated
| [tool.poetry.dependencies] | ||
| python = "^3.6" | ||
| allure-python-commons = "*" | ||
| bioblend = ">=0.14.0" |
There was a problem hiding this comment.
| bioblend = ">=0.14.0" | |
| bioblend = ">=0.16.0" |
xref. #1140 (review)
|
This is a project meant to be used as a library - I don't think it is appropriate to pin all the requirements so exactly like this. It makes it impossible to work with other applications and libraries. Can you produce a second requirements file for development? Maybe publish a planemo-app to PyPI that depends on Planemo and the exact requirements? |
|
I think it would make sense to have planemo be the primary thing we expect our users to install (given all the documentation and training that tells users to install planemo), so maybe we could instead create an unpinned planemo-lib if you want to build apps with planemo ? |
|
I disagree with this philosophy but I understand the motivation and clearly there is a problem with the current approach of Planemo. |
cbbdb22 to
ee383be
Compare
|
@jmchilton I've updated the PR to build a |
|
@jmchilton If this isn't acceptable we could mabe pin at least the galaxy-* packages to |
As an alternative to galaxyproject#1203
As an alternative to galaxyproject#1203
|
Superseded by #1230. |
As an alternative to galaxyproject#1203
That's the first time I set up poetry for a project, I'd appreciate your insights @nsoranzo @jmchilton