Skip to content

JOSS Paper content#37

Merged
j-i-l merged 42 commits intomainfrom
JOSSpaper_noT
May 20, 2024
Merged

JOSS Paper content#37
j-i-l merged 42 commits intomainfrom
JOSSpaper_noT

Conversation

@j-i-l
Copy link
Copy Markdown
Member

@j-i-l j-i-l commented Mar 20, 2024 •
edited by matteodelucchi
Loading

The branch JOSSpaper_noT gathers all paper specific content, including paper.md, paper.bib, etc.
Merge in main before submission. Do revisions during submission process on this branch then again.

Content that is relevant for abn package also outside the scope of the paper, but that was added/adapted/edited during the preparation of the paper should not reside in this branch.

j-i-l and others added 23 commits March 18, 2024 10:08
@j-i-l
try with suggested job and .Rmd format
c35c3e9
@j-i-l
follow suggeston for output
7cd4ece
@j-i-l
use normal .md for paper
ea6ac3c
@j-i-l
noT: Merge branch 'main' into JOSSpaper
eb8722b
@j-i-l
noT; actual .md file
e08461c
@j-i-l
noT; path from root
924759f
@j-i-l
noT: minor formatting
a52e3d3
@j-i-l
noT; fixing missing closing statement
d17a225
@j-i-l
noT; ok - now in the right file
83d3b78
@j-i-l
noT; with hyperlink
c60d9ac
@j-i-l
noT; with hyperlink - 2nd try
97e8cac
@j-i-l
noT; no hyperlink - keep it simple
d89a2c1
@matteodelucchi @j-i-l
coverage check after successful CRAN check. Closing #23.
0b63a0d
@matteodelucchi @j-i-l
noT; removing seperated coverage workflow. Relates to #23.
2285596
@j-i-l
start to publish releases (#35)
59f7ffd 
* start to publish releases

* noT; dev; temp. runc CRAN-like tests on this branch

* now trigger

* run CRAN-like check also on tags

* testing

* bug fix in worklfow

* removing dev edits
@j-i-l
typo
7f2e2e5
@j-i-l
closes #20; branch implements paper creation
edfac00
@j-i-l
Merge branch 'main' into JOSSpaper_noT
0aa7891
@j-i-l
using proper nouns for abbreviated terms
c433c83
@matteodelucchi
updated date to new planned submission date.
129db65
@matteodelucchi
Revised text according co-authors feedback. Addressing #47
84d5f91
@j-i-l
suggest: rephrasing of shortcomings
9d4d8b9
@j-i-l
Merge branch 'JOSSpaper_noT' of github.com:furrer-lab/abn into JOSSpa…
8ec2659 
…per_noT
@j-i-l j-i-l mentioned this pull request Mar 26, 2024
Merged
@j-i-l j-i-l requested a review from matteodelucchi March 26, 2024 11:19
@j-i-l
Copy link
Copy Markdown
Member Author

j-i-l commented Mar 26, 2024

@matteodelucchi 9d4d8b9 is just a suggestion, feel free to revert or adapt :)

@j-i-l
Copy link
Copy Markdown
Member Author

j-i-l commented Mar 26, 2024

@matteodelucchi I've also added a comment to https://github.com/orgs/furrer-lab/projects/1?pane=issue&itemId=57489555

@matteodelucchi
Copy link
Copy Markdown
Contributor

matteodelucchi commented Mar 26, 2024 •
edited
Loading

@matteodelucchi I've also added a comment to https://github.com/orgs/furrer-lab/projects/1?pane=issue&itemId=57489555

thanks, reads better without the repetition. Implemented here 5eb1538

matteodelucchi
matteodelucchi approved these changes Mar 26, 2024
View reviewed changes
@matteodelucchi
Merge pull request #49 from furrer-lab/main
5c3fd4b 
Merge main in JOSSpaper_noT
@matteodelucchi matteodelucchi marked this pull request as ready for review March 26, 2024 15:53
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.29%. Comparing base (3884e6a) to head (5c3fd4b).
Report is 13 commits behind head on main.

❗ Current head 5c3fd4b differs from pull request most recent head 71061ba

Please upload reports for the commit 71061ba to get more accurate results.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main      #37   +/-   ##
=======================================
  Coverage   66.29%   66.29%           
=======================================
  Files          53       53           
  Lines       10395    10395           
=======================================
  Hits         6891     6891           
  Misses       3504     3504

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

matteodelucchi
matteodelucchi requested changes Apr 17, 2024
View reviewed changes
@j-i-l j-i-l mentioned this pull request May 15, 2024
Closed
5 tasks
@j-i-l j-i-l self-assigned this May 20, 2024
@j-i-l j-i-l merged commit e031513 into main May 20, 2024
@matteodelucchi matteodelucchi deleted the JOSSpaper_noT branch May 22, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matteodelucchi matteodelucchi matteodelucchi requested changes

Assignees

@j-i-l j-i-l

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@j-i-l @matteodelucchi @reinhardfurrer